[Media Router] Add enable cloud services menu item to contextual menu.

chrome/browser/ui/toolbar/media_router_contextual_menu.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/metrics/user_metrics.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/media/router/media_router_factory.h"
 #include "chrome/browser/media/router/media_router_mojo_impl.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/toolbar/media_router_contextual_menu.h"
 #include "chrome/grit/generated_resources.h"
 #include "extensions/common/constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/menu_model_delegate.h"
 
+#if defined(GOOGLE_CHROME_BUILD)
+#include "base/prefs/pref_service.h"
+#include "chrome/common/pref_names.h"
+#endif  // defined(GOOGLE_CHROME_BUILD)
+
 MediaRouterContextualMenu::MediaRouterContextualMenu(Browser* browser)
     : browser_(browser),
       menu_model_(this) {
   menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_ABOUT,
                                   IDS_MEDIA_ROUTER_ABOUT);
   menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
+#if defined(GOOGLE_CHROME_BUILD)
+  menu_model_.AddCheckItemWithStringId(IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE,
+                                       IDS_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE);
+#endif  // defined(GOOGLE_CHROME_BUILD)
   menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_LEARN_MORE,
                                   IDS_MEDIA_ROUTER_LEARN_MORE);
   menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_HELP,
                                   IDS_MEDIA_ROUTER_HELP);
   menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
   menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_REPORT_ISSUE,
                                   IDS_MEDIA_ROUTER_REPORT_ISSUE);
 }
 
 MediaRouterContextualMenu::~MediaRouterContextualMenu() {
 }
 
 bool MediaRouterContextualMenu::IsCommandIdChecked(int command_id) const {
+#if defined(GOOGLE_CHROME_BUILD)
+  if (command_id == IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE) {
+    return browser_->profile()->GetPrefs()->GetBoolean(
+        prefs::kMediaRouterEnableCloudServices);
+  }
+#endif  // defined(GOOGLE_CHROME_BUILD)
   return false;
 }
 
 bool MediaRouterContextualMenu::IsCommandIdEnabled(int command_id) const {
   return true;
 }
 
+bool MediaRouterContextualMenu::IsCommandIdVisible(int command_id) const {
+#if defined(GOOGLE_CHROME_BUILD)
+  // Cloud services preference is not set or used if sync is disabled.
+  if (command_id == IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE)
+    return browser_->profile()->IsSyncAllowed();

[imcheng, 2016/01/26 18:35:45]

should we surface this command to users if they haven't gone through the cloud
services first run flow yet?

[apacible, 2016/01/26 19:27:34]

Yes, we (+pm, design) decided to surface the command even if they haven't
acknowledged the first run flow yet.

+#endif  // defined(GOOGLE_CHROME_BUILD)
+  return true;

[imcheng, 2016/01/26 18:35:45]

should this return false for the cloud services toggle in Chromium?

[apacible, 2016/01/26 19:27:34]

The cloud services toggle will not appear in Chromium.

+}
+
 bool MediaRouterContextualMenu::GetAcceleratorForCommandId(
     int command_id,
     ui::Accelerator* accelerator) {
   return false;
 }
 
 base::string16 MediaRouterContextualMenu::GetLabelForCommandId(
     int command_id) const {
   int string_id;

[imcheng, 2016/01/26 18:35:45]

nit: we should initialize string_id to 0 or some invalid value and then DCHECK
before using it.

[apacible, 2016/01/26 19:27:34]

Done.

   switch (command_id) {
     case IDC_MEDIA_ROUTER_ABOUT:
       string_id = IDS_MEDIA_ROUTER_ABOUT;
       break;
+#if defined(GOOGLE_CHROME_BUILD)
+    case IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE:
+      string_id = IDS_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE;
+      break;
+#endif  // defined(GOOGLE_CHROME_BUILD)
     case IDC_MEDIA_ROUTER_HELP:
       string_id = IDS_MEDIA_ROUTER_HELP;
       break;
     case IDC_MEDIA_ROUTER_LEARN_MORE:
       string_id = IDS_MEDIA_ROUTER_LEARN_MORE;
       break;
     case IDC_MEDIA_ROUTER_REPORT_ISSUE:
       string_id = IDS_MEDIA_ROUTER_REPORT_ISSUE;
       break;
     default:
@@ skipping 10 matching lines @@
       "https://www.google.com/chrome/devices/chromecast/";
   const char kCastHelpCenterPageUrl[] =
       "https://support.google.com/chromecast#topic=3058948";
   const char kCastLearnMorePageUrl[] =
       "https://www.google.com/chrome/devices/chromecast/learn.html";
 
   switch (command_id) {
     case IDC_MEDIA_ROUTER_ABOUT:
       chrome::ShowSingletonTab(browser_, GURL(kAboutPageUrl));
       break;
+#if defined(GOOGLE_CHROME_BUILD)
+    case IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE:
+      browser_->profile()->GetPrefs()->SetBoolean(

[imcheng, 2016/01/26 18:35:45]

would it be possible to extract browser_->profile()->GetPrefs() into a local
variable?

[apacible, 2016/01/26 19:27:34]

Done.

+          prefs::kMediaRouterEnableCloudServices,
+          !browser_->profile()->GetPrefs()->GetBoolean(
+              prefs::kMediaRouterEnableCloudServices));
+
+      // If this has been set before, this is a no-op.
+      browser_->profile()->GetPrefs()->SetBoolean(
+          prefs::kMediaRouterCloudServicesPrefSet,
+          true);
+      break;
+#endif  // defined(GOOGLE_CHROME_BUILD)
     case IDC_MEDIA_ROUTER_HELP:
       chrome::ShowSingletonTab(browser_, GURL(kCastHelpCenterPageUrl));
       base::RecordAction(base::UserMetricsAction(
           "MediaRouter_Ui_Navigate_Help"));
       break;
     case IDC_MEDIA_ROUTER_LEARN_MORE:
       chrome::ShowSingletonTab(browser_, GURL(kCastLearnMorePageUrl));
       break;
     case IDC_MEDIA_ROUTER_REPORT_ISSUE:
       ReportIssue();
@@ skipping 11 matching lines @@
           media_router::MediaRouterFactory::GetApiForBrowserContext(
               static_cast<content::BrowserContext*>(browser_->profile())));
   if (media_router->media_route_provider_extension_id().empty())
     return;
   std::string feedback_url(extensions::kExtensionScheme +
                            std::string(url::kStandardSchemeSeparator) +
                            media_router->media_route_provider_extension_id() +
                            "/feedback.html");
   chrome::ShowSingletonTab(browser_, GURL(feedback_url));
 }