Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 15821017: Use "Constructor" prefix for IDL extended attributes applying to the constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/IDLAttributes.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm
index a45c53b7b7e81b0e406417e8fa0fdfe82d9ac37f..487db19fd0ca7a6de41951d1e4c8922c314d0248 100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -2507,7 +2507,7 @@ sub GenerateSingleConstructorCallback
}
my $raisesExceptions = $function->signature->extendedAttributes->{"RaisesException"};
- if ($interface->extendedAttributes->{"RaisesException"}) {
+ if ($interface->extendedAttributes->{"ConstructorRaisesException"}) {
$raisesExceptions = 1;
}
if (!$raisesExceptions) {
@@ -2539,7 +2539,7 @@ END
my ($parameterCheckString, $paramIndex, %replacements) = GenerateParametersCheck($function, $interface, "");
$code .= $parameterCheckString;
- if ($interface->extendedAttributes->{"CallWith"} && $interface->extendedAttributes->{"CallWith"} eq "ScriptExecutionContext") {
+ if ($interface->extendedAttributes->{"ConstructorCallWith"} && $interface->extendedAttributes->{"ConstructorCallWith"} eq "ScriptExecutionContext") {
push(@beforeArgumentList, "context");
$code .= <<END;
@@ -2547,7 +2547,7 @@ END
END
}
- if ($interface->extendedAttributes->{"RaisesException"}) {
+ if ($interface->extendedAttributes->{"ConstructorRaisesException"}) {
push(@afterArgumentList, "ec");
}
@@ -2568,7 +2568,7 @@ END
$code .= " RefPtr<${implClassName}> impl = ${implClassName}::create(${argumentString});\n";
$code .= " v8::Handle<v8::Object> wrapper = args.Holder();\n";
- if ($interface->extendedAttributes->{"RaisesException"}) {
+ if ($interface->extendedAttributes->{"ConstructorRaisesException"}) {
$code .= " if (ec) {\n";
$code .= " setDOMException(ec, args.GetIsolate());\n";
$code .= " return;\n";
@@ -2731,7 +2731,7 @@ sub GenerateNamedConstructor
my $implClassName = GetImplName($interface);
my $v8ClassName = GetV8ClassName($interface);
my $raisesExceptions = $function->signature->extendedAttributes->{"RaisesException"};
- if ($interface->extendedAttributes->{"RaisesException"}) {
+ if ($interface->extendedAttributes->{"ConstructorRaisesException"}) {
$raisesExceptions = 1;
}
if (!$raisesExceptions) {
@@ -2794,7 +2794,7 @@ END
push(@beforeArgumentList, "document");
- if ($interface->extendedAttributes->{"RaisesException"}) {
+ if ($interface->extendedAttributes->{"ConstructorRaisesException"}) {
push(@afterArgumentList, "ec");
}
@@ -2815,7 +2815,7 @@ END
$code .= " RefPtr<${implClassName}> impl = ${implClassName}::createForJSConstructor(${argumentString});\n";
$code .= " v8::Handle<v8::Object> wrapper = args.Holder();\n";
- if ($interface->extendedAttributes->{"RaisesException"}) {
+ if ($interface->extendedAttributes->{"ConstructorRaisesException"}) {
$code .= " if (ec) {\n";
$code .= " setDOMException(ec, args.GetIsolate());\n";
$code .= " return;\n";
« no previous file with comments | « no previous file | Source/bindings/scripts/IDLAttributes.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698