Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15821017: Use "Constructor" prefix for IDL extended attributes applying to the constructor (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, feature-media-reviews_chromium.org, eae+blinkwatch, abarth-chromium, kinuko, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Nate Chapin, vcarbune.chromium, lgombos
Visibility:
Public.

Description

Use "Constructor" prefix for IDL extended attributes applying to the constructor [CallWith] and [RaisesException] IDL extended attributes are now renamed to [ConstructorCallWith] and [ConstructorRaisesException] respectively for IDL interfaces. This clarifies that those only apply to the constructor (and not all methods of the interface). This is also consistent with WebKit naming. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152290

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/scripts/IDLAttributes.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestInterface.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestNamedConstructor.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/WebKitCSSMatrix.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Comment.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentFragment.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessageChannel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReader.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaController.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackCue.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackRegion.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/SharedWorker.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/Worker.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileWriter.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/WebKitSourceBufferList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/MediaStream.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/Notification.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocket.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-12 14:58:31 UTC) #1
haraken
LGTM. Darin Adler's point makes sense: https://bugs.webkit.org/show_bug.cgi?id=117400#c7
7 years, 6 months ago (2013-06-12 15:15:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15821017/1
7 years, 6 months ago (2013-06-12 16:55:55 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 18:33:07 UTC) #4
Message was sent while issue was closed. 
Change committed as 152290

Powered by Google App Engine
This is Rietveld 408576698