Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 15821011: Implement ClassMirror.metadata. (Closed)

Created:
7 years, 6 months ago by ahe
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, ngeoffray, Johnni Winther, karlklose
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -24 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 4 chunks +10 lines, -9 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 1 chunk +3 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M dart/tests/lib/mirrors/metadata_test.dart View 1 chunk +26 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
7 years, 6 months ago (2013-05-30 18:41:25 UTC) #1
kasperl
LGTM!
7 years, 6 months ago (2013-05-31 06:24:36 UTC) #2
ahe
7 years, 6 months ago (2013-05-31 08:04:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698