Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1582093002: [DevTools] Turn NetworkConditionsSettingsTab into web component, move to network module. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Turn NetworkConditionsSettingsTab into web component, move to network module. BUG=575103 Committed: https://crrev.com/95e5d6692fde3a8160d8fb2081abbd7a27356bce Cr-Commit-Position: refs/heads/master@{#369319}

Patch Set 1 #

Messages

Total messages: 16 (7 generated)
dgozman
Take a look please.
4 years, 11 months ago (2016-01-13 20:16:21 UTC) #2
pfeldman
lgtm
4 years, 11 months ago (2016-01-13 20:19:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582093002/1
4 years, 11 months ago (2016-01-13 20:23:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years, 11 months ago (2016-01-13 23:39:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582093002/1
4 years, 11 months ago (2016-01-14 00:08:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/158996)
4 years, 11 months ago (2016-01-14 01:53:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582093002/1
4 years, 11 months ago (2016-01-14 02:18:25 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 03:58:38 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 04:01:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95e5d6692fde3a8160d8fb2081abbd7a27356bce
Cr-Commit-Position: refs/heads/master@{#369319}

Powered by Google App Engine
This is Rietveld 408576698