Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: src/codec/SkSwizzler.h

Issue 1582083005: Clean up unused or overly complex modes in SkSwizzler (Closed) Base URL: https://skia.googlesource.com/skia.git@neon-unpremul
Patch Set: Response to comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/codec/SkJpegCodec.cpp ('k') | src/codec/SkSwizzler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codec/SkSwizzler.h
diff --git a/src/codec/SkSwizzler.h b/src/codec/SkSwizzler.h
index e75ab43cfe0c90c5daf0f313443d0624bec0b859..edc7dcbe2a9838f0583d87de9efaa052bc82b2b8 100644
--- a/src/codec/SkSwizzler.h
+++ b/src/codec/SkSwizzler.h
@@ -20,7 +20,7 @@ public:
*/
enum SrcConfig {
kUnknown, // Invalid type.
- kBit, // A single bit to distinguish between white and black
+ kBit, // A single bit to distinguish between white and black.
kGray,
kIndex1,
kIndex2,
@@ -28,12 +28,13 @@ public:
kIndex,
kRGB,
kBGR,
- kRGBX,
- kBGRX,
+ kBGRX, // The alpha channel can be anything, but the image is opaque.
kRGBA,
kBGRA,
- kRGB_565,
kCMYK,
+ kNoOp8, // kNoOp modes are used exclusively for sampling, subsetting, and
+ kNoOp16, // copying. The pixels themselves do not need to be modified.
+ kNoOp32,
};
/*
@@ -52,17 +53,18 @@ public:
return 4;
case kGray:
case kIndex:
+ case kNoOp8:
return 8;
- case kRGB_565:
+ case kNoOp16:
return 16;
case kRGB:
case kBGR:
return 24;
- case kRGBX:
case kRGBA:
case kBGRX:
case kBGRA:
case kCMYK:
+ case kNoOp32:
return 32;
default:
SkASSERT(false);
« no previous file with comments | « src/codec/SkJpegCodec.cpp ('k') | src/codec/SkSwizzler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698