Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1582083002: net: move GetIdentifyFromURL function into url_util.h (Closed)

Created:
4 years, 11 months ago by tfarina
Modified:
4 years, 11 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: move GetIdentifyFromURL function into url_util.h This seems to be a more appropriate place for this function, than the generic net_util.h header file, which will soon be gone. BUG=488531 TEST=net_unittests R=eroman@chromium.org Committed: https://crrev.com/c38cb957636e2cdada1a4d2ac509fc0a3f54590d Cr-Commit-Position: refs/heads/master@{#369403}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -120 lines) Patch
M net/base/net_util.h View 2 chunks +0 lines, -11 lines 3 comments Download
M net/base/net_util.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M net/base/net_util_unittest.cc View 4 chunks +4 lines, -89 lines 0 comments Download
M net/base/url_util.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/base/url_util.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M net/base/url_util_unittest.cc View 2 chunks +77 lines, -0 lines 0 comments Download
M net/ftp/ftp_network_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
tfarina
4 years, 11 months ago (2016-01-13 19:20:45 UTC) #1
eroman
lgtm! https://codereview.chromium.org/1582083002/diff/1/net/base/net_util.h File net/base/net_util.h (right): https://codereview.chromium.org/1582083002/diff/1/net/base/net_util.h#newcode63 net/base/net_util.h:63: NET_EXPORT std::string GetHostOrSpecFromURL(const GURL& url); This is a ...
4 years, 11 months ago (2016-01-13 20:21:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582083002/1
4 years, 11 months ago (2016-01-13 23:01:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-13 23:39:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582083002/1
4 years, 11 months ago (2016-01-13 23:43:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-14 01:10:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582083002/1
4 years, 11 months ago (2016-01-14 01:16:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-14 01:53:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582083002/1
4 years, 11 months ago (2016-01-14 12:41:01 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 12:45:08 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 12:46:04 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c38cb957636e2cdada1a4d2ac509fc0a3f54590d
Cr-Commit-Position: refs/heads/master@{#369403}

Powered by Google App Engine
This is Rietveld 408576698