Chromium Code Reviews Chromium Code Reviews
Issue 1582043002:
Add histograms for data usage (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 49aa452bbb54c688253b4ddd0676e913634e60bf..d5c40f474f8e9014c2ab1c2b20dfe4d8028877ae 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -6566,6 +6566,56 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="DataUsage.MatchingRulesCount.Invalid" units="count"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>rajendrant@chromium.org</owner> |
| + <summary> |
| + The number of invalid matching rules fetched from the platform external data |
| + use observer. A sample is recorded everytime fetch done callback was called. |
|
tbansal1
2016/01/15 17:11:19
nit: Either s/is/was/ OR s/was/is/
It seems s/was/
Raj
2016/01/15 18:27:02
Done.
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DataUsage.MatchingRulesCount.Valid" units="count"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>rajendrant@chromium.org</owner> |
| + <summary> |
| + The number of valid matching rules fetched from the platform external data |
| + use observer. A sample is recorded everytime fetch done callback was called. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DataUsage.Perf.MatchingRuleFirstFetchDuration" |
| + units="millsecond"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>rajendrant@chromium.org</owner> |
| + <summary> |
| + The time taken to fetch the matching rules for the first time from the |
| + platform external data use observer. This measures the duration from the |
| + start time of Chrome to the time the rules are returned asynchronously. A |
|
tbansal1
2016/01/15 17:11:19
s/Chrome/Chromium/
Raj
2016/01/15 18:27:02
Done.
|
| + sample is recorded once when fetch done callback was called. |
|
tbansal1
2016/01/15 17:11:19
s/once when fetch/when the first fetch/
Raj
2016/01/15 18:27:02
Done.
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DataUsage.Perf.ReportSubmissionDuration" units="millisecond"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>rajendrant@chromium.org</owner> |
| + <summary> |
| + The time taken to submit the data use reports to the platform external data |
| + use observer. This measures the duration from the time reports are submitted |
|
tbansal1
2016/01/15 17:11:19
s/reports are submitted/report submission/
Raj
2016/01/15 18:27:02
Done.
|
| + to the time report submitted asynchronous callback was received. A sample is |
| + recorded everytime report submission done callback was received. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DataUsage.Perf.URLRegexMatchDuration" units="millisecond"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>rajendrant@chromium.org</owner> |
| + <summary> |
| + The time taken for a regular expression to process an URL. A sample is |
|
tbansal1
2016/01/15 17:11:19
s/process/parse/
s/processing/parsing/
Raj
2016/01/15 18:27:02
Done.
|
| + recorded evertime regular expression processing is done for an URL. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="DataUsage.ReportSubmission.Bytes" units="bytes"> |
| <owner>bengr@chromium.org</owner> |
| <owner>tbansal@chromium.org</owner> |
