chrome/browser/android/data_usage/external_data_use_observer.cc - Issue 1582043002: Add histograms for data usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer.cc

Issue 1582043002: Add histograms for data usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed holte comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/data_usage/external_data_use_observer.cc

diff --git a/chrome/browser/android/data_usage/external_data_use_observer.cc b/chrome/browser/android/data_usage/external_data_use_observer.cc

index 94e9e0607003bfd3c5f19c56a7f22dae867d9a14..a1dba79a73f3b54b3b09cc35fe3d352f6c4ec5ab 100644

--- a/chrome/browser/android/data_usage/external_data_use_observer.cc

+++ b/chrome/browser/android/data_usage/external_data_use_observer.cc

@@ -205,6 +205,9 @@ void ExternalDataUseObserver::OnReportDataUseDone(bool success) {

RecordDataUsageReportSubmission(DATAUSAGE_REPORT_SUBMISSION_FAILED,

pending_report_bytes_);

}

+ UMA_HISTOGRAM_TIMES(

+ "DataUsage.Perf.ReportSubmissionDuration",

+ base::TimeTicks::Now() - last_data_report_submitted_ticks_);

last_data_report_submitted_ticks_ = base::TimeTicks();

pending_report_bytes_ = 0;