Add histograms for data usage

chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/data_usage/external_data_use_observer.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
@@ skipping 15 matching lines @@
 #include "components/sessions/core/session_id.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "net/base/network_change_notifier.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace {
 
+const char kUMAMatchingRuleFirstFetchDurationHistogram[] =
+    "DataUsage.Perf.MatchingRuleFirstFetchDuration";
+const char kUMAReportSubmissionDurationHistogram[] =
+    "DataUsage.Perf.ReportSubmissionDuration";
+
 const char kDefaultLabel[] = "label";
 const SessionID::id_type kDefaultTabId = 0;
 const char kDefaultURL[] = "http://www.google.com/#q=abc";
 const char kFooMccMnc[] = "foo_mccmnc";
 const char kBarMccMnc[] = "bar_mccmnc";
 const char kBazMccMnc[] = "baz_mccmnc";
 const char kFooLabel[] = "foo_label";
 const char kBarLabel[] = "bar_label";
 
 }  // namespace
@@ skipping 414 matching lines @@
   external_data_use_observer()->OnReportDataUseDone(true);
 
   // Verify that metrics were updated correctly for the report that was
   // successfully submitted.
   histogram_tester.ExpectUniqueSample(
       "DataUsage.ReportSubmissionResult",
       ExternalDataUseObserver::DATAUSAGE_REPORT_SUBMISSION_SUCCESSFUL, 1);
   histogram_tester.ExpectUniqueSample(
       "DataUsage.ReportSubmission.Bytes.Successful",
       external_data_use_observer()->data_use_report_min_bytes_, 1);
+  histogram_tester.ExpectTotalCount(kUMAReportSubmissionDurationHistogram, 1);
 
   // Verify that metrics were updated correctly for the report that was not
   // successfully submitted.
   OnDataUse(default_data_use());
   external_data_use_observer()->OnReportDataUseDone(false);
   histogram_tester.ExpectTotalCount("DataUsage.ReportSubmissionResult", 2);
   histogram_tester.ExpectBucketCount(
       "DataUsage.ReportSubmissionResult",
       ExternalDataUseObserver::DATAUSAGE_REPORT_SUBMISSION_FAILED, 1);
   histogram_tester.ExpectUniqueSample(
       "DataUsage.ReportSubmission.Bytes.Failed",
       external_data_use_observer()->data_use_report_min_bytes_, 1);
+  histogram_tester.ExpectTotalCount(kUMAReportSubmissionDurationHistogram, 2);
 }
 
 #if defined(OS_ANDROID)
 // Tests data use report submission when application status callback is called.
 // Report should be submitted even if the number of bytes is less than the
 // threshold. Report should not be submitted if there is a pending report.
 TEST_F(ExternalDataUseObserverTest, DataUseReportingOnApplicationStatusChange) {
+  base::HistogramTester histogram_tester;
   AddDefaultMatchingRule();
   TriggerTabTrackingOnDefaultTab();
 
   // Report with less than threshold bytes should be reported, on application
   // state change to background.
   data_usage::DataUse data_use = default_data_use();
   data_use.tx_bytes = 1;
   data_use.rx_bytes = 1;
   OnDataUse(data_use);
   EXPECT_TRUE(external_data_use_observer()
                   ->last_data_report_submitted_ticks_.is_null());
   EXPECT_EQ(2, external_data_use_observer()->total_bytes_buffered_);
   EXPECT_EQ(0, external_data_use_observer()->pending_report_bytes_);
 
   external_data_use_observer()->OnApplicationStateChange(
       base::android::APPLICATION_STATE_HAS_PAUSED_ACTIVITIES);
   EXPECT_FALSE(external_data_use_observer()
                    ->last_data_report_submitted_ticks_.is_null());
   EXPECT_EQ(0, external_data_use_observer()->total_bytes_buffered_);
   EXPECT_EQ(2, external_data_use_observer()->pending_report_bytes_);
   external_data_use_observer()->OnReportDataUseDone(true);
+  histogram_tester.ExpectTotalCount(kUMAReportSubmissionDurationHistogram, 1);
 
   // Create pending report.
   OnDataUse(default_data_use());
   EXPECT_FALSE(external_data_use_observer()
                    ->last_data_report_submitted_ticks_.is_null());
   EXPECT_EQ(0, external_data_use_observer()->total_bytes_buffered_);
   EXPECT_EQ(default_upload_bytes() + default_download_bytes(),
             external_data_use_observer()->pending_report_bytes_);
 
   // Application state change should not submit if there is a pending report.
   data_use.tx_bytes = 1;
   data_use.rx_bytes = 1;
   OnDataUse(data_use);
   external_data_use_observer()->OnApplicationStateChange(
       base::android::APPLICATION_STATE_HAS_PAUSED_ACTIVITIES);
   EXPECT_FALSE(external_data_use_observer()
                    ->last_data_report_submitted_ticks_.is_null());
   EXPECT_EQ(2, external_data_use_observer()->total_bytes_buffered_);
   EXPECT_EQ(default_upload_bytes() + default_download_bytes(),
             external_data_use_observer()->pending_report_bytes_);
+  histogram_tester.ExpectTotalCount(kUMAReportSubmissionDurationHistogram, 1);
 
   // Once pending report submission done callback was received, report should be
   // submitted on next application state change.
   external_data_use_observer()->OnReportDataUseDone(true);
   external_data_use_observer()->OnApplicationStateChange(
       base::android::APPLICATION_STATE_HAS_PAUSED_ACTIVITIES);
   EXPECT_EQ(0, external_data_use_observer()->total_bytes_buffered_);
   EXPECT_EQ(2, external_data_use_observer()->pending_report_bytes_);
+  histogram_tester.ExpectTotalCount(kUMAReportSubmissionDurationHistogram, 2);
 }
 #endif // OS_ANDROID
 
 // Tests if the parameters from the field trial are populated correctly.
 TEST_F(ExternalDataUseObserverTest, Variations) {
   std::map<std::string, std::string> variation_params;
 
   const int kFetchMatchingRulesDurationSeconds = 10000;
   const int kDefaultMaxDataReportSubmitWaitMsec = 20000;
   const int64_t kDataUseReportMinBytes = 5000;
@@ skipping 10 matching lines @@
             external_data_use_observer()->fetch_matching_rules_duration_);
   EXPECT_EQ(
       base::TimeDelta::FromMilliseconds(kDefaultMaxDataReportSubmitWaitMsec),
       external_data_use_observer()->data_report_submit_timeout_);
   EXPECT_EQ(kDataUseReportMinBytes,
             external_data_use_observer()->data_use_report_min_bytes_);
 }
 
 // Tests if the metrics are recorded correctly.
 TEST_F(ExternalDataUseObserverTest, DataUseReportTimedOut) {
+  base::HistogramTester histogram_tester;
   std::map<std::string, std::string> variation_params;
   variation_params["data_report_submit_timeout_msec"] = "0";
   variation_params["data_use_report_min_bytes"] = "0";
 
   // Create another ExternalDataUseObserver object.
   ReplaceExternalDataUseObserver(variation_params);
+  histogram_tester.ExpectTotalCount(kUMAMatchingRuleFirstFetchDurationHistogram,
+                                    1);
+
   AddDefaultMatchingRule();
 
-  base::HistogramTester histogram_tester;
   TriggerTabTrackingOnDefaultTab();
   OnDataUse(default_data_use());
   OnDataUse(default_data_use());
   // First data use report should be marked as timed out.
   histogram_tester.ExpectUniqueSample(
       "DataUsage.ReportSubmissionResult",
       ExternalDataUseObserver::DATAUSAGE_REPORT_SUBMISSION_TIMED_OUT, 1);
   histogram_tester.ExpectUniqueSample(
       "DataUsage.ReportSubmission.Bytes.TimedOut",
       default_upload_bytes() + default_download_bytes(), 1);
+  histogram_tester.ExpectTotalCount(kUMAReportSubmissionDurationHistogram, 0);
 }
 
 }  // namespace android
 
 }  // namespace chrome