Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1582033002: dart2js cps: Remove redundant traversal from variable merger pass. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Remove redundant traversal from variable merger pass. This was a leftover from when we had nested functions in the IR. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/2dd2a0d3f709e8c0bc8130632ee50d9f25810102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 11 months ago (2016-01-13 17:35:30 UTC) #2
Kevin Millikin (Google)
LGTM.
4 years, 11 months ago (2016-01-13 17:56:06 UTC) #3
asgerf
4 years, 11 months ago (2016-01-14 18:53:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2dd2a0d3f709e8c0bc8130632ee50d9f25810102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698