|
|
Revert 202716 "Reland 201932: Add API function chrome.notificati..."
Broke Mac ASAN Tests (2):
NotificationsApiTest.TestGetAll:
dyld: warning, unknown environment variable: DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
[5768:3847:0528/182240:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
../../chrome/browser/extensions/api/notifications/notifications_apitest.cc:331: Failure
Value of: kNotificationsToCreate
Actual: 4
Expected: return_value->size()
Which is: 0
> Reland 201932: Add API function chrome.notifications.getAll
>
> This function returns an object whose keys are the notification
> IDs of all notifications created by that extension.
>
> BUG= 240924
>
> TBR=miket@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/15715008
TBR=dewittj@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202764
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+18 lines, -246 lines) |
Patch |
 |
MM |
trunk/src/chrome/browser/extensions/api/notifications/notifications_api.h
|
View
|
|
1 chunk |
+0 lines, -14 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/extensions/api/notifications/notifications_api.cc
|
View
|
|
6 chunks |
+17 lines, -47 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/extensions/api/notifications/notifications_apitest.cc
|
View
|
|
3 chunks |
+0 lines, -78 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/balloon_notification_ui_manager.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/balloon_notification_ui_manager.cc
|
View
|
|
2 chunks |
+0 lines, -21 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/message_center_notification_manager.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/message_center_notification_manager.cc
|
View
|
|
2 chunks |
+1 line, -20 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/notification_ui_manager.h
|
View
|
|
2 chunks |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/notification_ui_manager.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/notification_ui_manager_impl.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/notification_ui_manager_impl.cc
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc
|
View
|
|
4 chunks |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc
|
View
|
|
4 chunks |
+0 lines, -13 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/common/extensions/api/notifications.idl
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
15820009:
Revert 202716 "Reland 201932: Add API function chrome.notificati..." (Closed)
