Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15820008: Remove library dart:crypto (Closed)

Created:
7 years, 6 months ago by Søren Gjesse
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove library dart:crypto Moved the contnet of dart:crypto to the package pkg/crypto. R=dgrove@google.com, floitsch@google.com, iposva@google.com, nweiz@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23322

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -908 lines) Patch
A + pkg/crypto/lib/crypto.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + pkg/crypto/lib/src/crypto_utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/crypto/lib/src/hash_utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/crypto/lib/src/hmac.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/crypto/lib/src/md5.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/crypto/lib/src/sha1.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/crypto/lib/src/sha256.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/crypto/pubspec.yaml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/http/lib/src/utils.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/oauth2/lib/src/utils.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/benchmark_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/bootstrap.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/object_store.h View 4 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/vm.gypi View 4 chunks +0 lines, -36 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/crypto/crypto.dart View 1 chunk +0 lines, -182 lines 0 comments Download
D sdk/lib/crypto/crypto_utils.dart View 1 chunk +0 lines, -161 lines 0 comments Download
D sdk/lib/crypto/hash_utils.dart View 1 chunk +0 lines, -154 lines 0 comments Download
D sdk/lib/crypto/hmac.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D sdk/lib/crypto/md5.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D sdk/lib/crypto/sha1.dart View 1 chunk +0 lines, -67 lines 0 comments Download
D sdk/lib/crypto/sha256.dart View 1 chunk +0 lines, -105 lines 0 comments Download
M tests/lib/crypto/base64_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/crypto/hmac_md5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/crypto/hmac_sha1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/crypto/hmac_sha256_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/crypto/sha1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/crypto/sha256_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_auth_digest_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_auth_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Søren Gjesse
Dan, are there any additional steps required for the package pkg/crypto to be created?
7 years, 6 months ago (2013-05-28 16:21:50 UTC) #1
Søren Gjesse
7 years, 6 months ago (2013-05-28 16:23:17 UTC) #2
floitsch
LGTM. Did you forget to upload the pubspec file? Please wait for the ok from ...
7 years, 6 months ago (2013-05-28 16:31:18 UTC) #3
dgrove
On 2013/05/28 16:31:18, floitsch wrote: > LGTM. > Did you forget to upload the pubspec ...
7 years, 6 months ago (2013-05-28 16:32:32 UTC) #4
dgrove
lgtm
7 years, 6 months ago (2013-05-28 16:32:41 UTC) #5
Ivan Posva
LGTM -ip
7 years, 6 months ago (2013-05-28 17:46:59 UTC) #6
nweiz
One nit, otherwise LGTM. https://codereview.chromium.org/15820008/diff/1/pkg/http/lib/src/utils.dart File pkg/http/lib/src/utils.dart (right): https://codereview.chromium.org/15820008/diff/1/pkg/http/lib/src/utils.dart#newcode16 pkg/http/lib/src/utils.dart:16: Extra newline.
7 years, 6 months ago (2013-05-28 18:35:04 UTC) #7
Søren Gjesse
Committed patchset #2 manually as r23322 (presubmit successful).
7 years, 6 months ago (2013-05-29 07:29:58 UTC) #8
Søren Gjesse
7 years, 6 months ago (2013-05-29 07:38:08 UTC) #9
Message was sent while issue was closed. 
Added pubspec.yaml as well.

https://codereview.chromium.org/15820008/diff/1/pkg/http/lib/src/utils.dart
File pkg/http/lib/src/utils.dart (right):

https://codereview.chromium.org/15820008/diff/1/pkg/http/lib/src/utils.dart#n...
pkg/http/lib/src/utils.dart:16: 
On 2013/05/28 18:35:04, nweiz wrote:
> Extra newline.

Removed.

Powered by Google App Engine
This is Rietveld 408576698