Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1581993002: Make summary builder classes implement summary interfaces. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make summary builder classes implement summary interfaces. This allows for easier unit testing, since we can use a builder class directly rather than having to serialize and deserialize it. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c1642e9d9f57be18300416abe9d0f9c3c01a0e08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+714 lines, -313 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 188 chunks +660 lines, -261 lines 0 comments Download
M pkg/analyzer/test/src/summary/name_filter_test.dart View 14 chunks +20 lines, -37 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 6 chunks +34 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-13 16:34:11 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-13 16:39:33 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-13 16:54:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1642e9d9f57be18300416abe9d0f9c3c01a0e08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698