Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1581963009: Mark analyzer/test/file_system/physical_resource_provider_test as Pass, Fail. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark analyzer/test/file_system/physical_resource_provider_test as Pass, Fail. R=brianwilkerson@google.com, whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/659c9b44e2c1fde955e3aca751c57ef24f4e71a6

Patch Set 1 #

Patch Set 2 : Move to VM, add issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/pkg.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
scheglov
4 years, 11 months ago (2016-01-14 17:27:13 UTC) #1
Bill Hesse
Does not LGTM without an issue filed and an issue number in a comment after ...
4 years, 11 months ago (2016-01-14 17:30:56 UTC) #3
scheglov
PTAL
4 years, 11 months ago (2016-01-14 17:37:54 UTC) #4
Bill Hesse
lgtm
4 years, 11 months ago (2016-01-14 17:42:07 UTC) #5
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-14 17:47:02 UTC) #6
scheglov
4 years, 11 months ago (2016-01-14 18:28:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
659c9b44e2c1fde955e3aca751c57ef24f4e71a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698