Do not use invalidated std::map::iterators in PDF_ReplaceAbbr().

Do not use invalidated std::map::iterators in PDF_ReplaceAbbr().

Avoid invalidating iterators by deferring the std::map operations.

Also remove unused PDF_ReplaceFull().

BUG=577030
R=ochang@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/5d1070dc642800242ec2e9d9d74aa1e5715d2b62

[Lei Zhang, 2016-01-13 23:43:54]

thestig@chromium.org changed reviewers:
+ ochang@chromium.org

[Oliver Chang, 2016-01-13 23:54:42]

lgtm, thanks for fixing this. I'll take care of the remaining occurrences.

[Oliver Chang, 2016-01-14 00:07:52]

actually, PDF_ReplaceFull needs a similar change...

[Oliver Chang, 2016-01-14 00:18:35]

and these functions recurse too... i'll try to address this in my CL too unless
you're already on it.

[Oliver Chang, 2016-01-14 00:22:02]

On 2016/01/14 00:18:35, Oliver Chang wrote:
> and these functions recurse too... i'll try to address this in my CL too
unless
> you're already on it.

actually, disregard. I misread the code.

[Lei Zhang, 2016-01-14 01:00:52]

On 2016/01/14 00:07:52, Oliver Chang wrote:
> actually, PDF_ReplaceFull needs a similar change...

PDF_ReplaceFull() is actually dead code. Its only caller is itself. I'll remove
it...

[Lei Zhang, 2016-01-14 01:03:32]

Description was changed from

==========
Do not use invalidated std::map::iterators in PDF_ReplaceAbbr().

Avoid invalidating iterators by deferring the std::map operations.

BUG=577030
==========

to

==========
Do not use invalidated std::map::iterators in PDF_ReplaceAbbr().

Avoid invalidating iterators by deferring the std::map operations.

Also remove unused PDF_ReplaceFull().

BUG=577030
==========

[Lei Zhang, 2016-01-14 01:04:38]

Description was changed from

==========
Do not use invalidated std::map::iterators in PDF_ReplaceAbbr().

Avoid invalidating iterators by deferring the std::map operations.

Also remove unused PDF_ReplaceFull().

BUG=577030
==========

to

==========
Do not use invalidated std::map::iterators in PDF_ReplaceAbbr().

Avoid invalidating iterators by deferring the std::map operations.

Also remove unused PDF_ReplaceFull().

BUG=577030
R=ochang@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/5d1070dc642800242ec2e9d9d74aa1e5715d...
==========

[Lei Zhang, 2016-01-14 01:04:39]

Committed patchset #3 (id:40001) manually as
5d1070dc642800242ec2e9d9d74aa1e5715d2b62 (presubmit successful).

[Lei Zhang, 2016-01-14 01:15:02]

On 2016/01/14 00:18:35, Oliver Chang wrote:
> and these functions recurse too... i'll try to address this in my CL too
unless
> you're already on it.

Oh, I already landed before I got a chance to look at your CL. Hope you don't
mind. You can always undo this CL in yours.

[Oliver Chang, 2016-01-14 01:19:00]

On 2016/01/14 01:15:02, Lei Zhang wrote:
> On 2016/01/14 00:18:35, Oliver Chang wrote:
> > and these functions recurse too... i'll try to address this in my CL too
> unless
> > you're already on it.
> 
> Oh, I already landed before I got a chance to look at your CL. Hope you don't
> mind. You can always undo this CL in yours.

Or we could just keep yours :)