Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1581933004: Audio Player: Close the player on Ctrl-W. (Closed)

Created:
4 years, 11 months ago by fukino
Modified:
4 years, 11 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audio Player: Close the player on Ctrl-W. BUG=570588 TEST=manually Committed: https://crrev.com/aba1ef6276e0339cf12035e727b87a47086c690d Cr-Commit-Position: refs/heads/master@{#369357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/file_manager/audio_player/js/audio_player.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
fukino
PTAL. Thanks!
4 years, 11 months ago (2016-01-14 02:47:28 UTC) #2
yawano
lgtm. Thank you!
4 years, 11 months ago (2016-01-14 03:26:49 UTC) #3
fukino
On 2016/01/14 03:26:49, yawano wrote: > lgtm. Thank you! Thanks!
4 years, 11 months ago (2016-01-14 04:15:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581933004/1
4 years, 11 months ago (2016-01-14 04:16:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 06:19:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581933004/1
4 years, 11 months ago (2016-01-14 06:35:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 06:57:43 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 06:58:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aba1ef6276e0339cf12035e727b87a47086c690d
Cr-Commit-Position: refs/heads/master@{#369357}

Powered by Google App Engine
This is Rietveld 408576698