Allow asm modules to be instatiated with external heaps.

Allow asm modules to be instatiated with external heaps.

This merges the instantiation logic between instantiateModule
and instantiateModuleFromAsm.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=asm-wasm
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/3dcbc57e7359d0127cdc77e2c4b402d128dabefb
Cr-Commit-Position: refs/heads/master@{#33316}

[aseemgarg, 2016-01-14 22:08:04]

lgtm

See one comment

https://codereview.chromium.org/1581913005/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/1581913005/diff/1/src/wasm/wasm-js.cc#newcode248
src/wasm/wasm-js.cc:248: thrower.Error("!!!!BBBBBB Asm module text should be a
string");
Don't know what !!!!BBBBBB means..

[bradn, 2016-01-14 22:39:18]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-01-14 22:39:18]

https://codereview.chromium.org/1581913005/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/1581913005/diff/1/src/wasm/wasm-js.cc#newcode248
src/wasm/wasm-js.cc:248: thrower.Error("!!!!BBBBBB Asm module text should be a
string");
On 2016/01/14 22:08:04, aseemgarg wrote:
> Don't know what !!!!BBBBBB means..

Oops, leftover, dropping.

[bradn, 2016-01-14 22:39:22]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-01-14 22:39:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
aseemgarg@chromium.org
Link to the patchset: https://codereview.chromium.org/1581913005/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-01-14 22:39:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581913005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581913005/20001

[commit-bot: I haz the power, 2016-01-14 23:08:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 23:09:08]

Description was changed from

==========
Allow asm modules to be instatiated with external heaps.

This merges the instantiation logic between instantiateModule
and instantiateModuleFromAsm.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=asm-wasm
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

to

==========
Allow asm modules to be instatiated with external heaps.

This merges the instantiation logic between instantiateModule
and instantiateModuleFromAsm.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=asm-wasm
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/3dcbc57e7359d0127cdc77e2c4b402d128dabefb
Cr-Commit-Position: refs/heads/master@{#33316}
==========

[commit-bot: I haz the power, 2016-01-14 23:09:09]

Patchset 2 (id:??) landed as
https://crrev.com/3dcbc57e7359d0127cdc77e2c4b402d128dabefb
Cr-Commit-Position: refs/heads/master@{#33316}