Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1581853002: dart2js cps: Copy allocation site type when cloning. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Copy allocation site type when cloning. Currently makes no difference because type propagation is not run after inlining, but it will be needed. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/a3cf74fdda591d27f1c0a63b6ceed1d84841bffd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 11 months ago (2016-01-12 23:48:14 UTC) #2
Kevin Millikin (Google)
lgtm
4 years, 11 months ago (2016-01-13 00:29:05 UTC) #3
asgerf
4 years, 11 months ago (2016-01-13 00:38:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3cf74fdda591d27f1c0a63b6ceed1d84841bffd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698