Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1581823002: Resolve fde_xml.h header collision (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3024 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fdp/include/fde_xml.h View 2 chunks +5 lines, -3 lines 0 comments Download
D xfa/src/fdp/src/xml/fde_xml.h View 1 chunk +0 lines, -373 lines 0 comments Download
D xfa/src/fdp/src/xml/fde_xml.cpp View 1 chunk +0 lines, -2638 lines 0 comments Download
A + xfa/src/fdp/src/xml/fde_xml_imp.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + xfa/src/fdp/src/xml/fde_xml_imp.cpp View 2 chunks +2 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, for review.
4 years, 11 months ago (2016-01-12 22:05:16 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/1581823002/diff/1/xfa/src/fdp/src/xml/fde_xml_imp.cpp File xfa/src/fdp/src/xml/fde_xml_imp.cpp (right): https://codereview.chromium.org/1581823002/diff/1/xfa/src/fdp/src/xml/fde_xml_imp.cpp#newcode10 xfa/src/fdp/src/xml/fde_xml_imp.cpp:10: #include "fde_xml_imp.h" xfa/src/fdp/src/xml/fde_xml_imp.h, and move it to the ...
4 years, 11 months ago (2016-01-12 22:27:24 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-19 23:18:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4a2aa1a90d89b88036b0bff432ffefa183ea80d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698