Remove -Wno-unknown-pragmas from fusl build

Remove -Wno-unknown-pragmas from fusl build

Clang does not, and is not likely to soon, support C's rounding mode
pragmas. See https://llvm.org/bugs/show_bug.cgi?id=8100 for details.

R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/6e820932f4d7b4f1fe7352ae3291d568cdc08062

[kulakowski, 2016-01-12 20:30:22]

Open to alternative ways to deal with this as well, this seemed straightforward
and preserves some information we may one day care about.

[viettrungluu, 2016-01-12 23:38:26]

LGTM w/added comment.

https://codereview.chromium.org/1581793002/diff/1/fusl/src/internal/libm.h
File fusl/src/internal/libm.h (right):

https://codereview.chromium.org/1581793002/diff/1/fusl/src/internal/libm.h#ne...
fusl/src/internal/libm.h:1: /* origin: FreeBSD
/usr/src/lib/msun/src/math_private.h */
I guess this file is only included by implementation files, not by public .h
files. Phew.

https://codereview.chromium.org/1581793002/diff/1/fusl/src/internal/libm.h#ne...
fusl/src/internal/libm.h:22: #ifdef __clang__
Could you add a comment explaining this? (Include in your comment the clang/llvm
bug # or maybe a link to the bug, and/or file a tracking bug for fusl and
include a link to it here.)

[kulakowski, 2016-01-13 00:04:50]

https://codereview.chromium.org/1581793002/diff/1/fusl/src/internal/libm.h
File fusl/src/internal/libm.h (right):

https://codereview.chromium.org/1581793002/diff/1/fusl/src/internal/libm.h#ne...
fusl/src/internal/libm.h:1: /* origin: FreeBSD
/usr/src/lib/msun/src/math_private.h */
On 2016/01/12 23:38:25, viettrungluu wrote:
> I guess this file is only included by implementation files, not by public .h
> files. Phew.

Yup.

https://codereview.chromium.org/1581793002/diff/1/fusl/src/internal/libm.h#ne...
fusl/src/internal/libm.h:22: #ifdef __clang__
On 2016/01/12 23:38:26, viettrungluu wrote:
> Could you add a comment explaining this? (Include in your comment the
clang/llvm
> bug # or maybe a link to the bug, and/or file a tracking bug for fusl and
> include a link to it here.)

Yeah, I'll do that.

[kulakowski, 2016-01-13 00:10:17]

Description was changed from

==========
Remove -Wno-unknown-pragmas from fusl build

Clang does not, and is not likely to soon, support C's rounding mode
pragmas. See https://llvm.org/bugs/show_bug.cgi?id=8100 for details.

R=viettrungluu@chromium.org
==========

to

==========
Remove -Wno-unknown-pragmas from fusl build

Clang does not, and is not likely to soon, support C's rounding mode
pragmas. See https://llvm.org/bugs/show_bug.cgi?id=8100 for details.

R=viettrungluu@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/6e820932f4d7b4f1fe7352ae329...
==========

[kulakowski, 2016-01-13 00:10:18]

Committed patchset #2 (id:20001) manually as
6e820932f4d7b4f1fe7352ae3291d568cdc08062 (presubmit successful).