Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1581773005: mojo_run: infer --origin from `MOJO_VERSION` file if present. (Closed)

Created:
4 years, 11 months ago by ppi
Modified:
4 years, 11 months ago
Reviewers:
tonyg, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

mojo_run: infer --origin from `MOJO_VERSION` file if present. This allows mojo consumers that use pinned mojo version not to set --origin to point to the correct google storage directory manually - it will be set based on MOJO_VERSION if MOJO_VERSION is present AND --origin is not passed explicitly. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d34ebee9950ba27b50ef8f78d29c2bb3e6d6dc51

Patch Set 1 #

Patch Set 2 : Address Tony's comments. #

Patch Set 3 : Add a verbose printout. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -20 lines) Patch
M mojo/devtools/common/devtoolslib/paths.py View 2 chunks +13 lines, -8 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_config.py View 1 2 4 chunks +27 lines, -12 lines 0 comments Download
M mojo/devtools/common/docs/mojo_run.md View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ppi
Hi Ben or Tony, ptal.
4 years, 11 months ago (2016-01-13 14:11:12 UTC) #2
tonyg
Good idea, this lgtm A couple of thoughts though: 1. It'd be nice if the ...
4 years, 11 months ago (2016-01-13 14:38:05 UTC) #3
ppi
Thanks, Tony! The default origin value is calculated at runtime (depends on whether we run ...
4 years, 11 months ago (2016-01-13 16:44:30 UTC) #4
ppi
Also added a --verbose printout to facilitate debugging, e.g.: "Inferring origin from `MOJO_VERSION` as: https://storage.googleapis.com/mojo/services/android-arm/f9e73ad5730fbd29e312809b4ac6017d40c69691"
4 years, 11 months ago (2016-01-13 16:48:01 UTC) #5
ppi
4 years, 11 months ago (2016-01-13 16:48:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d34ebee9950ba27b50ef8f78d29c2bb3e6d6dc51 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698