Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1581773003: Roll chromium to fix java_cpp_enum.py (Closed)

Created:
4 years, 11 months ago by fbarchard1
Modified:
4 years, 11 months ago
Reviewers:
fbarchard, jkellander
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Roll chromium to fix java_cpp_enum.py Remove assumption on absolute paths in java_cpp_enum.py. In java_cpp_enum.py there were assumptions on 'build' being a component of the absolute path of the script invoking the script. This leads to problems when other projects are using the Chromium build toolchain (in this case libyuv), where the script invoking GYP is located in the root of the project dir (https://chromium.googlesource.com/libyuv/libyuv/+/master/gyp_libyuv). TBR=harryjin@google.com, jkellander@chromium.org BUG=libyuv:536 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/d1c6eb0887e83fb03e00aa9c35be59a26e4735a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
fbarchard1
4 years, 11 months ago (2016-01-13 01:10:31 UTC) #1
fbarchard
This resolves the gyp issue but causes a build error ../../third_party/gflags/src/gflags.cc:281:53: error: unused typedef 'true_false_equal' ...
4 years, 11 months ago (2016-01-13 02:37:33 UTC) #4
fbarchard
disabled warning in gtest.gyp/build.gn. builds 32 bit linux now.
4 years, 11 months ago (2016-01-14 19:39:05 UTC) #5
fbarchard1
4 years, 11 months ago (2016-01-14 19:39:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1c6eb0887e83fb03e00aa9c35be59a26e4735a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698