Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1581753002: Remove Chrome OS-related GN build configuration (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 if (is_mac) { 97 if (is_mac) {
98 cflags += [ "-fstack-protector-all" ] 98 cflags += [ "-fstack-protector-all" ]
99 } else if (is_linux) { 99 } else if (is_linux) {
100 cflags += [ 100 cflags += [
101 "-fstack-protector", 101 "-fstack-protector",
102 "--param=ssp-buffer-size=4", 102 "--param=ssp-buffer-size=4",
103 ] 103 ]
104 } 104 }
105 105
106 # Linker warnings. 106 # Linker warnings.
107 if (!(is_chromeos && current_cpu == "arm") && !is_mac && !is_ios) { 107 if (!is_mac && !is_ios) {
108 # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580
109 ldflags += [ "-Wl,--fatal-warnings" ] 108 ldflags += [ "-Wl,--fatal-warnings" ]
110 } 109 }
111 110
112 # Common options for AddressSanitizer, LeakSanitizer, ThreadSanitizer and 111 # Common options for AddressSanitizer, LeakSanitizer, ThreadSanitizer and
113 # MemorySanitizer 112 # MemorySanitizer
114 if (using_sanitizer) { 113 if (using_sanitizer) {
115 cflags += [ 114 cflags += [
116 "-fno-omit-frame-pointer", 115 "-fno-omit-frame-pointer",
117 "-gline-tables-only", 116 "-gline-tables-only",
118 ] 117 ]
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 # http://crbug.com/492177. Turning it on saves over 12 MB of binary 418 # http://crbug.com/492177. Turning it on saves over 12 MB of binary
420 # size, but it seems to regress cold startup time by over a second 419 # size, but it seems to regress cold startup time by over a second
421 # (see http://crbug.com/492809). 420 # (see http://crbug.com/492809).
422 # TODO(thakis): Check if disabling ICF would inmprove android cold start 421 # TODO(thakis): Check if disabling ICF would inmprove android cold start
423 # times by several seconds too. 422 # times by several seconds too.
424 ldflags += [ "-Wl,--icf=safe" ] 423 ldflags += [ "-Wl,--icf=safe" ]
425 } else { 424 } else {
426 ldflags += [ "-Wl,--icf=all" ] 425 ldflags += [ "-Wl,--icf=all" ]
427 } 426 }
428 } 427 }
429
430 # TODO(thestig): Make this flag work with GN.
431 #if (!is_official_build && !is_chromeos && !(is_asan || is_lsan || is_tsan | | is_msan)) {
432 # ldflags += [
433 # "-Wl,--detect-odr-violations",
434 # ]
435 #}
436 } 428 }
437 429
438 if (linux_use_bundled_binutils) { 430 if (linux_use_bundled_binutils) {
439 binutils_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin", 431 binutils_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin",
440 root_build_dir) 432 root_build_dir)
441 cflags += [ "-B$binutils_path" ] 433 cflags += [ "-B$binutils_path" ]
442 } 434 }
443 435
444 # Clang-specific compiler flags setup. 436 # Clang-specific compiler flags setup.
445 # ------------------------------------ 437 # ------------------------------------
(...skipping 681 matching lines...) Expand 10 before | Expand all | Expand 10 after
1127 if (symbol_level == 0) { 1119 if (symbol_level == 0) {
1128 configs = [ ":no_symbols" ] 1120 configs = [ ":no_symbols" ]
1129 } else if (symbol_level == 1) { 1121 } else if (symbol_level == 1) {
1130 configs = [ ":minimal_symbols" ] 1122 configs = [ ":minimal_symbols" ]
1131 } else if (symbol_level == 2) { 1123 } else if (symbol_level == 2) {
1132 configs = [ ":symbols" ] 1124 configs = [ ":symbols" ]
1133 } else { 1125 } else {
1134 assert(false) 1126 assert(false)
1135 } 1127 }
1136 } 1128 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698