src/arguments.cc - Issue 15817014: remove most uses of raw handle constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arguments.cc

Issue 15817014: remove most uses of raw handle constructors (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: stupid cast needed Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arguments.cc

diff --git a/src/arguments.cc b/src/arguments.cc

index 091d0b92a47af1bd61377ce155f142ef9e078b17..b15ae7ea647140a8baa80d1067d1a351b205a805 100644

--- a/src/arguments.cc

+++ b/src/arguments.cc

@@ -82,7 +82,7 @@ v8::Handle<V> CustomArguments<T>::GetReturnValue(Isolate* isolate) {

Object** handle = &this->end()[kReturnValueOffset];

// Nothing was set, return empty handle as per previous behaviour.

if ((*handle)->IsTheHole()) return v8::Handle<V>();

- return v8::Handle<V>(reinterpret_cast<V*>(handle));

+ return Utils::Convert<Object, V>(Handle<Object>(handle));

}

« no previous file with comments | « src/api.cc ('k') | src/d8.cc » ('j') | no next file with comments »