Issue 15817003: drive: Use OperationTestBase from CreateDirectoryOperationTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15817003: drive: Use OperationTestBase from CreateDirectoryOperationTest (Closed)

Created:
7 years, 7 months ago by hashimoto

Modified:
7 years, 7 months ago

Reviewers:
commit-bot: I haz the power, kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Use OperationTestBase from CreateDirectoryOperationTest Replace FileSystemTest.CreateDirectory with CreateDirectoryOperationTest.CreateDirectory. FileSystemTest.CreateDirectoryByImplicitLoad is left unchanged because it's testing that LoadIfNeeded is called by FileSystem::CreateDirectory. BUG=244168 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202516

Patch Set 1 : #

Patch Set 2 : rebase #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -187 lines)			Patch
M	chrome/browser/chromeos/drive/file_system/create_directory_operation.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc	View		1 chunk	+90 lines, -151 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View	1	2 chunks	+0 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/15817003/4001

7 years, 7 months ago (2013-05-28 04:47:16 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=154366

7 years, 7 months ago (2013-05-28 07:32:20 UTC) #4

hashimoto

7 years, 7 months ago (2013-05-28 08:07:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r202516 (presubmit successful).

Expand Messages | Collapse Messages