Remove races in window creation in Files.app.

chrome/browser/resources/file_manager/js/test_util.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Namespace for test related things.
  */
 var test = test || {};
 
 /**
  * Namespace for test utility functions.
  */
 test.util = {};
 
 /**
  * Extension ID of the testing extension.
  * @type {string}
  * @const
  */
 test.util.TESTING_EXTENSION_ID = 'oobinhbdbiehknkpbpejbbpdbkdjmoco';
 
 /**
  * Opens the main Files.app's window and waits until it is ready.
  *
  * @param {string} path Path of the directory to be opened.
  * @param {function(string)} callback Completion callback with the new window's
  *     App ID.
  */
 test.util.openMainWindow = function(path, callback) {
-  var appId = launchFileManager({defaultPath: path});
+  var appId;
   function helper() {
     if (appWindows[appId]) {
       var contentWindow = appWindows[appId].contentWindow;
       var table = contentWindow.document.querySelector('#detail-table');
       if (table) {
         callback(appId);
         return;
       }
     }
     window.setTimeout(helper, 50);
   }
-  helper();
+  launchFileManager({defaultPath: path},
+                    undefined,  // opt_type
+                    undefined,  // opt_id
+                    function(id) {
+                      appId = id;
+                      helper();
+                    });
 };
 
 /**
  * Gets total Javascript error count from each app window.
  * @return {number} Error count.
  */
 test.util.getErrorCount = function() {
   var totalCount = 0;
   for (var appId in appWindows) {
     var contentWindow = appWindows[appId].contentWindow;
@@ skipping 414 matching lines @@
         default:
           console.error('Window function ' + request.func + ' not found.');
       }
     }
     return false;
   });
 };
 
 // Register the test utils.
 test.util.registerRemoteTestUtils();