Remove races in window creation in Files.app.

chrome/browser/resources/file_manager/js/background.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Map of all currently open app window. The key is an app id.
  */
 var appWindows = {};
@@ skipping 264 matching lines @@
     minHeight: 240,
     frame: util.platform.newUI() ? 'none' : 'chrome',
     transparentBackground: true
   };
 }
 
 /**
  * @param {Object=} opt_appState App state.
  * @param {number=} opt_id Window id.
  * @param {LaunchType=} opt_type Launch type. Default: ALWAYS_CREATE.
- * @return {string} The window's App ID.
  */
 function launchFileManager(opt_appState, opt_id, opt_type) {
   var type = opt_type || LaunchType.ALWAYS_CREATE;
 
-  // Check if there is already a window with the same path. If so, then
-  // reuse it instead of opening a new one.
-  if (type == LaunchType.FOCUS_SAME_OR_CREATE ||
-      type == LaunchType.FOCUS_ANY_OR_CREATE) {
-    if (opt_appState && opt_appState.defaultPath) {
-      for (var key in appWindows) {
-        var contentWindow = appWindows[key].contentWindow;
-        if (contentWindow.appState &&
-            opt_appState.defaultPath == contentWindow.appState.defaultPath) {
-          appWindows[key].focus();
-          return key;
+  // Wait until all windows are created.
+  queue.run(function(callback) {
+    // Check if there is already a window with the same path. If so, then
+    // reuse it instead of opening a new one.
+    if (type == LaunchType.FOCUS_SAME_OR_CREATE ||
+        type == LaunchType.FOCUS_ANY_OR_CREATE) {
+      if (opt_appState && opt_appState.defaultPath) {
+        for (var key in appWindows) {
+          var contentWindow = appWindows[key].contentWindow;
+          if (contentWindow.appState &&
+              opt_appState.defaultPath == contentWindow.appState.defaultPath) {
+            appWindows[key].focus();
+            callback();
+            return;
+          }
         }
       }
     }
-  }
 
-  // Focus any window if none is focused. Try restored first.
-  if (type == LaunchType.FOCUS_ANY_OR_CREATE) {
-    // If there is already a focused window, then finish.
-    for (var key in appWindows) {
-      // The isFocused() method should always be available, but in case
-      // Files.app's failed on some error, wrap it with try catch.
-      try {
-        if (appWindows[key].contentWindow.isFocused())
-          return key;
-      } catch (e) {
-        console.error(e.message);
+    // Focus any window if none is focused. Try restored first.
+    if (type == LaunchType.FOCUS_ANY_OR_CREATE) {
+      // If there is already a focused window, then finish.
+      for (var key in appWindows) {
+        // The isFocused() method should always be available, but in case
+        // Files.app's failed on some error, wrap it with try catch.
+        try {
+          if (appWindows[key].contentWindow.isFocused())
+            return key;
+        } catch (e) {
+          console.error(e.message);
+        }
+      }
+      // Try to focus the first non-minimized window.
+      for (var key in appWindows) {
+        if (!appWindows[key].isMinimized()) {
+          appWindows[key].focus();
+          callback();
+          return;
+        }
+      }
+      // Restore and focus any window.
+      for (var key in appWindows) {
+        appWindows[key].focus();
+        callback();
+        return;
       }
     }
-    // Try to focus the first non-minimized window.
-    for (var key in appWindows) {
-      if (!appWindows[key].isMinimized()) {
-        appWindows[key].focus();
-        return key;
-      }
-    }
-    // Restore and focus any window.
-    for (var key in appWindows) {
-      appWindows[key].focus();
-      return key;
-    }
-  }
 
-  // Create a new instance in case of ALWAYS_CREATE type, or as a fallback
-  // for other types.
+    // Create a new instance in case of ALWAYS_CREATE type, or as a fallback
+    // for other types.
 
-  var id = opt_id || nextFileManagerWindowID;
-  nextFileManagerWindowID = Math.max(nextFileManagerWindowID, id + 1);
-  var appId = FILES_ID_PREFIX + id;
+    var id = opt_id || nextFileManagerWindowID;
+    nextFileManagerWindowID = Math.max(nextFileManagerWindowID, id + 1);
+    var appId = FILES_ID_PREFIX + id;
 
-  var appWindow = new AppWindowWrapper(
-      queue,
-      util.platform.newUI() ? 'main_new_ui.html' : 'main.html',
-      appId,
-      createFileManagerOptions);
-  appWindow.enqueueLaunch(opt_appState || {});
-
-  return appId;
+    var appWindow = new AppWindowWrapper(
+        queue,
+        util.platform.newUI() ? 'main_new_ui.html' : 'main.html',
+        appId,
+        createFileManagerOptions);
+    appWindow.enqueueLaunch(opt_appState || {});
+    callback();
+  });

[yoshiki, 2013/05/23 06:49:21]

In test_util.js, the retual value is used. Could you modify test_util.js?

[mtomasz, 2013/05/23 07:17:30]

Done.

 }
 
 /**
  * Relaunch file manager windows based on the persisted state.
  */
 function reopenFileManagers() {
   chrome.storage.local.get(function(items) {
     for (var key in items) {
       if (items.hasOwnProperty(key)) {
         var match = key.match(FILES_ID_PATTERN);
@@ skipping 132 matching lines @@
 }
 
 chrome.app.runtime.onLaunched.addListener(launch);
 chrome.app.runtime.onRestarted.addListener(restart);
 
 function addExecuteHandler() {
   chrome.fileBrowserHandler.onExecute.addListener(executeFileBrowserTask);
 }
 
 addExecuteHandler();