Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1581693010: Add support for (de)serializing HeadsUpDisplayLayer (Closed)

Created:
4 years, 11 months ago by nyquist
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, krasin1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for (de)serializing HeadsUpDisplayLayer They LayerTreeHost has a HUD-layer as a member, and as part of the CL for adding support for (de)serializing the LayerTreeHost, the test code incorrectly creates a cc:Layer instead of a cc:HeadsUpDisplayLayer, and this is not checked. The Linux CFI bot luckily caught this error, so this CL fixes the error by adding support for the layer type. The HUD layer has no special members, but do have some special logic for drawing, so only the type needed to be serialized. BUG=577972 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7e179407a1a73a3c03be9dfc7f34f066a1edd3b0 Cr-Commit-Position: refs/heads/master@{#369916}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix naming nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M cc/layers/heads_up_display_layer.h View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/layers/heads_up_display_layer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/layers/layer_proto_converter.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/layers/layer_proto_converter_unittest.cc View 1 2 chunks +33 lines, -0 lines 0 comments Download
M cc/proto/layer.proto View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_serialization.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
nyquist
vmpstr, dtrainor: PTAL krasin: FYI
4 years, 11 months ago (2016-01-15 21:27:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581693010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581693010/1
4 years, 11 months ago (2016-01-15 21:28:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 22:36:51 UTC) #7
vmpstr
lgtm https://codereview.chromium.org/1581693010/diff/1/cc/layers/layer_proto_converter_unittest.cc File cc/layers/layer_proto_converter_unittest.cc (right): https://codereview.chromium.org/1581693010/diff/1/cc/layers/layer_proto_converter_unittest.cc#newcode407 cc/layers/layer_proto_converter_unittest.cc:407: TEST_F(LayerProtoConverterTest, HUDLayerTypeSerialization) { nit: I prefer lowercase ud ...
4 years, 11 months ago (2016-01-15 23:01:39 UTC) #8
nyquist
https://codereview.chromium.org/1581693010/diff/1/cc/layers/layer_proto_converter_unittest.cc File cc/layers/layer_proto_converter_unittest.cc (right): https://codereview.chromium.org/1581693010/diff/1/cc/layers/layer_proto_converter_unittest.cc#newcode407 cc/layers/layer_proto_converter_unittest.cc:407: TEST_F(LayerProtoConverterTest, HUDLayerTypeSerialization) { On 2016/01/15 23:01:39, vmpstr wrote: > ...
4 years, 11 months ago (2016-01-15 23:09:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581693010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581693010/20001
4 years, 11 months ago (2016-01-15 23:10:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-16 01:51:18 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 01:52:08 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e179407a1a73a3c03be9dfc7f34f066a1edd3b0
Cr-Commit-Position: refs/heads/master@{#369916}

Powered by Google App Engine
This is Rietveld 408576698