Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1581653002: Revert of WebRTC: Enable OpenH264 for WebRTC standalone bots. (Closed)

Created:
4 years, 11 months ago by kjellander_chromium
Modified:
4 years, 11 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

Revert of WebRTC: Enable OpenH264 for WebRTC standalone bots. (patchset #2 id:20001 of https://codereview.chromium.org/1577773002/ ) Reason for revert: Breaks on Win GN https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28GN%29/builds/2985 and probably more (will add more info to the revert CL). Original issue's description: > WebRTC: Enable OpenH264 for WebRTC standalone bots. > > hbos@ in the WebRTC team is working on enabling OpenH264 as an H.264 > encoder in Chrome as part of http://crbug.com/468365. This CL sets the > necessary GYP variables to turn it on in the build for standalone WebRTC > bots and the Chromium bots we control. > > NOTICE: Due to licensing and patent reasons, OpenH264 cannot be enabled > by default for end-users. Going forward, the plan is that it will only be > enabled on WebRTC controlled bots and the Chromium official builders. > > BUG=576201 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298217 TBR=tandrii@chromium.org,hbos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=576201 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -141 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +0 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/chromium_config.py View 3 chunks +6 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/libfuzzer.expected/full_tryserver_webrtc_linux_libfuzzer_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gn.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gn__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_ios64_debug__gn_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_ios64_release__gn_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux32_arm.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_release__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_ubsan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_ubsan_vptr.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac64_release__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_release__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios32_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios32_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios32_simulator_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios64_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios64_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios64_simulator_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__gn_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gn_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__large_tests_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug__gn_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__gn_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__large_tests_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__gn_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__gn_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_full.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_light.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_syzyasan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios32_sim_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios64_gn_dbg.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios64_gn_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios64_sim_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_arm64_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_arm64_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg_legacy_svn_patch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn_dbg.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_swarming.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_dbg.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_swarming.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_full.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_light.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gn_dbg.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gn_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kjellander_chromium
Created Revert of WebRTC: Enable OpenH264 for WebRTC standalone bots.
4 years, 11 months ago (2016-01-12 14:57:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581653002/1
4 years, 11 months ago (2016-01-12 14:57:15 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 14:57:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298218

Powered by Google App Engine
This is Rietveld 408576698