Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 1581643004: [wasm] Add tests for JS wrappers to test-run-wasm. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add tests for JS wrappers to test-run-wasm. R=bradnelson@chromium.org, ahaas@chromium.org BUG= Committed: https://crrev.com/c52f5ced4e600a57c02301f2936b80f086613985 Cr-Commit-Position: refs/heads/master@{#33274}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+552 lines, -381 lines) Patch
M src/wasm/wasm-js.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/wasm-js.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 2 chunks +2 lines, -375 lines 1 comment Download
A test/cctest/wasm/test-run-wasm-js.cc View 1 chunk +141 lines, -0 lines 0 comments Download
A test/cctest/wasm/wasm-run-utils.h View 1 chunk +391 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
4 years, 11 months ago (2016-01-13 18:47:52 UTC) #1
bradnelson
lgtm https://codereview.chromium.org/1581643004/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (left): https://codereview.chromium.org/1581643004/diff/1/test/cctest/wasm/test-run-wasm.cc#oldcode51 test/cctest/wasm/test-run-wasm.cc:51: env->module = nullptr; Glad to see all this ...
4 years, 11 months ago (2016-01-13 19:32:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581643004/1
4 years, 11 months ago (2016-01-13 19:32:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 19:56:08 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c52f5ced4e600a57c02301f2936b80f086613985 Cr-Commit-Position: refs/heads/master@{#33274}
4 years, 11 months ago (2016-01-13 19:57:01 UTC) #7
adamk
4 years, 11 months ago (2016-01-13 21:00:45 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1587763002/ by adamk@chromium.org.

The reason for reverting is: New test failed on nosnap builder
(https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2...):

Test: cctest/test-run-wasm-js/Run_CallJS_Add_jswrapped

Stderr:
abort: Sloppy function expects JSReceiver as receiver.

#
# Fatal error in ../../src/objects-inl.h, line 3221
# Check failed: !v8::internal::FLAG_enable_slow_asserts ||
(object->IsJSFunction()).
#.

Powered by Google App Engine
This is Rietveld 408576698