Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15816002: Remove console.profiles from window.console API (Closed)

Created:
7 years, 7 months ago by yurys
Modified:
7 years, 7 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove console.profiles from window.console API This change removes profiles property from window.console objec and all related classes. console.profile/profileEnd can still be used to record profile but the profiles themselves should be retrieved only using remote debugging protocol. BUG=240531 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151136

Patch Set 1 #

Patch Set 2 : Removed some comments #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -413 lines) Patch
A LayoutTests/inspector-protocol/cpu-profiler/console-profile.html View 1 1 chunk +77 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/cpu-profiler/console-profile-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/cpu-profiler/console-profileEnd-parameterless-crash.html View 1 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/cpu-profiler/console-profileEnd-parameterless-crash-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/inspector-protocol/cpu-profiler/record-cpu-profile.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D LayoutTests/inspector/profiler/cpu-profiler-parameterless-profile-end-crash.html View 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/inspector/profiler/cpu-profiler-parameterless-profile-end-crash-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector.html View 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/core.gypi View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/inspector/ScriptProfile.h View 4 chunks +1 line, -5 lines 0 comments Download
M Source/core/inspector/ScriptProfile.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D Source/core/inspector/ScriptProfile.idl View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
D Source/core/inspector/ScriptProfileNode.h View 1 chunk +0 lines, -79 lines 0 comments Download
D Source/core/inspector/ScriptProfileNode.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
D Source/core/inspector/ScriptProfileNode.idl View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
M Source/core/page/Console.h View 1 2 4 chunks +0 lines, -6 lines 0 comments Download
M Source/core/page/Console.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/Console.idl View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 7 months ago (2013-05-23 05:00:50 UTC) #1
loislo
On 2013/05/23 05:00:50, Yury Semikhatsky wrote: lgtm needs rebaseline
7 years, 7 months ago (2013-05-24 13:30:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/15816002/5001
7 years, 7 months ago (2013-05-24 17:25:39 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6553
7 years, 7 months ago (2013-05-24 21:24:36 UTC) #4
yurys
7 years, 7 months ago (2013-05-24 21:39:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r151136 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698