Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1581593004: dart2js cps: Do redundant join elimination after inlining. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Do redundant join elimination after inlining. Redundant join elimination can enable optimizations in GVN and BCE, and redundant joins can occur after inlining a method used in a condition, such as isEmpty or isNotEmpty. BUG= R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/add29e3cbaaac04c2fce9658562f322b9660cb88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 11 months ago (2016-01-12 23:06:30 UTC) #2
Harry Terkelsen
lgtm
4 years, 11 months ago (2016-01-12 23:19:34 UTC) #3
asgerf
4 years, 11 months ago (2016-01-13 22:17:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
add29e3cbaaac04c2fce9658562f322b9660cb88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698