Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 1581593003: Skip PaintPhaseFloat if no floats in a layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@OutlinePhase
Patch Set: Remove test (instead of #if 0) Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
624 void setPreviousPaintDirtyRect(const LayoutRect& rect) { m_previousPaintDirt yRect = rect; } 624 void setPreviousPaintDirtyRect(const LayoutRect& rect) { m_previousPaintDirt yRect = rect; }
625 625
626 PaintLayerPainter::PaintResult previousPaintResult() const { return static_c ast<PaintLayerPainter::PaintResult>(m_previousPaintResult); } 626 PaintLayerPainter::PaintResult previousPaintResult() const { return static_c ast<PaintLayerPainter::PaintResult>(m_previousPaintResult); }
627 void setPreviousPaintResult(PaintLayerPainter::PaintResult result) { m_previ ousPaintResult = static_cast<unsigned>(result); ASSERT(m_previousPaintResult == static_cast<unsigned>(result)); } 627 void setPreviousPaintResult(PaintLayerPainter::PaintResult result) { m_previ ousPaintResult = static_cast<unsigned>(result); ASSERT(m_previousPaintResult == static_cast<unsigned>(result)); }
628 628
629 // Used to skip PaintPhaseDescendantOutlinesOnly for layers that have never had descendant outlines. 629 // Used to skip PaintPhaseDescendantOutlinesOnly for layers that have never had descendant outlines.
630 // Once it's set we never clear it because it's not easy to track if all out lines have been removed. 630 // Once it's set we never clear it because it's not easy to track if all out lines have been removed.
631 bool needsPaintPhaseDescendantOutlines() const { return m_needsPaintPhaseDes cendantOutlines; } 631 bool needsPaintPhaseDescendantOutlines() const { return m_needsPaintPhaseDes cendantOutlines; }
632 void setNeedsPaintPhaseDescendantOutlines() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseDescendantOutlines = true; } 632 void setNeedsPaintPhaseDescendantOutlines() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseDescendantOutlines = true; }
633 633
634 // Similar to above, but for PaintPhaseFloat.
635 bool needsPaintPhaseFloat() const { return m_needsPaintPhaseFloat; }
636 void setNeedsPaintPhaseFloat() { ASSERT(isSelfPaintingLayer()); m_needsPaint PhaseFloat = true; }
637
634 PaintTiming* paintTiming(); 638 PaintTiming* paintTiming();
635 639
636 private: 640 private:
637 // Bounding box in the coordinates of this layer. 641 // Bounding box in the coordinates of this layer.
638 LayoutRect logicalBoundingBox() const; 642 LayoutRect logicalBoundingBox() const;
639 643
640 bool hasOverflowControls() const; 644 bool hasOverflowControls() const;
641 645
642 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus(); 646 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
643 647
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 unsigned m_shouldIsolateCompositedDescendants : 1; 761 unsigned m_shouldIsolateCompositedDescendants : 1;
758 762
759 // True if this layout layer just lost its grouped mapping due to the Compos itedLayerMapping being destroyed, 763 // True if this layout layer just lost its grouped mapping due to the Compos itedLayerMapping being destroyed,
760 // and we don't yet know to what graphics layer this Layer will be assigned. 764 // and we don't yet know to what graphics layer this Layer will be assigned.
761 unsigned m_lostGroupedMapping : 1; 765 unsigned m_lostGroupedMapping : 1;
762 766
763 unsigned m_needsRepaint : 1; 767 unsigned m_needsRepaint : 1;
764 unsigned m_previousPaintResult : 1; // PaintLayerPainter::PaintResult 768 unsigned m_previousPaintResult : 1; // PaintLayerPainter::PaintResult
765 769
766 unsigned m_needsPaintPhaseDescendantOutlines : 1; 770 unsigned m_needsPaintPhaseDescendantOutlines : 1;
771 unsigned m_needsPaintPhaseFloat : 1;
767 772
768 LayoutBoxModelObject* m_layoutObject; 773 LayoutBoxModelObject* m_layoutObject;
769 774
770 PaintLayer* m_parent; 775 PaintLayer* m_parent;
771 PaintLayer* m_previous; 776 PaintLayer* m_previous;
772 PaintLayer* m_next; 777 PaintLayer* m_next;
773 PaintLayer* m_first; 778 PaintLayer* m_first;
774 PaintLayer* m_last; 779 PaintLayer* m_last;
775 780
776 // Our current relative position offset. 781 // Our current relative position offset.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 836
832 } // namespace blink 837 } // namespace blink
833 838
834 #ifndef NDEBUG 839 #ifndef NDEBUG
835 // Outside the WebCore namespace for ease of invocation from gdb. 840 // Outside the WebCore namespace for ease of invocation from gdb.
836 void showLayerTree(const blink::PaintLayer*); 841 void showLayerTree(const blink::PaintLayer*);
837 void showLayerTree(const blink::LayoutObject*); 842 void showLayerTree(const blink::LayoutObject*);
838 #endif 843 #endif
839 844
840 #endif // Layer_h 845 #endif // Layer_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698