Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 1581593003: Skip PaintPhaseFloat if no floats in a layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@OutlinePhase
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 void setPreviousPaintDirtyRect(const LayoutRect& rect) { m_previousPaintDirt yRect = rect; } 621 void setPreviousPaintDirtyRect(const LayoutRect& rect) { m_previousPaintDirt yRect = rect; }
622 622
623 PaintLayerPainter::PaintResult previousPaintResult() const { return static_c ast<PaintLayerPainter::PaintResult>(m_previousPaintResult); } 623 PaintLayerPainter::PaintResult previousPaintResult() const { return static_c ast<PaintLayerPainter::PaintResult>(m_previousPaintResult); }
624 void setPreviousPaintResult(PaintLayerPainter::PaintResult result) { m_previ ousPaintResult = static_cast<unsigned>(result); ASSERT(m_previousPaintResult == static_cast<unsigned>(result)); } 624 void setPreviousPaintResult(PaintLayerPainter::PaintResult result) { m_previ ousPaintResult = static_cast<unsigned>(result); ASSERT(m_previousPaintResult == static_cast<unsigned>(result)); }
625 625
626 // Used to skip PaintPhaseDescendantOutlinesOnly for layers that have never had descendant outlines. 626 // Used to skip PaintPhaseDescendantOutlinesOnly for layers that have never had descendant outlines.
627 // Once it's set we never clear it because it's not easy to track if all out lines have been removed. 627 // Once it's set we never clear it because it's not easy to track if all out lines have been removed.
628 bool needsPaintPhaseDescendantOutlines() const { return m_needsPaintPhaseDes cendantOutlines; } 628 bool needsPaintPhaseDescendantOutlines() const { return m_needsPaintPhaseDes cendantOutlines; }
629 void setNeedsPaintPhaseDescendantOutlines() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseDescendantOutlines = true; } 629 void setNeedsPaintPhaseDescendantOutlines() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseDescendantOutlines = true; }
630 630
631 // Similar to above, but for PaintPhaseFloat.
632 bool needsPaintPhaseFloat() const { return m_needsPaintPhaseFloat; }
633 void setNeedsPaintPhaseFloat() { ASSERT(isSelfPaintingLayer()); m_needsPaint PhaseFloat = true; }
634
631 PaintTiming* paintTiming(); 635 PaintTiming* paintTiming();
632 636
633 private: 637 private:
634 // Bounding box in the coordinates of this layer. 638 // Bounding box in the coordinates of this layer.
635 LayoutRect logicalBoundingBox() const; 639 LayoutRect logicalBoundingBox() const;
636 640
637 bool hasOverflowControls() const; 641 bool hasOverflowControls() const;
638 642
639 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus(); 643 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
640 644
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
754 unsigned m_shouldIsolateCompositedDescendants : 1; 758 unsigned m_shouldIsolateCompositedDescendants : 1;
755 759
756 // True if this layout layer just lost its grouped mapping due to the Compos itedLayerMapping being destroyed, 760 // True if this layout layer just lost its grouped mapping due to the Compos itedLayerMapping being destroyed,
757 // and we don't yet know to what graphics layer this Layer will be assigned. 761 // and we don't yet know to what graphics layer this Layer will be assigned.
758 unsigned m_lostGroupedMapping : 1; 762 unsigned m_lostGroupedMapping : 1;
759 763
760 unsigned m_needsRepaint : 1; 764 unsigned m_needsRepaint : 1;
761 unsigned m_previousPaintResult : 1; // PaintLayerPainter::PaintResult 765 unsigned m_previousPaintResult : 1; // PaintLayerPainter::PaintResult
762 766
763 unsigned m_needsPaintPhaseDescendantOutlines : 1; 767 unsigned m_needsPaintPhaseDescendantOutlines : 1;
768 unsigned m_needsPaintPhaseFloat : 1;
764 769
765 LayoutBoxModelObject* m_layoutObject; 770 LayoutBoxModelObject* m_layoutObject;
766 771
767 PaintLayer* m_parent; 772 PaintLayer* m_parent;
768 PaintLayer* m_previous; 773 PaintLayer* m_previous;
769 PaintLayer* m_next; 774 PaintLayer* m_next;
770 PaintLayer* m_first; 775 PaintLayer* m_first;
771 PaintLayer* m_last; 776 PaintLayer* m_last;
772 777
773 // Our current relative position offset. 778 // Our current relative position offset.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 833
829 } // namespace blink 834 } // namespace blink
830 835
831 #ifndef NDEBUG 836 #ifndef NDEBUG
832 // Outside the WebCore namespace for ease of invocation from gdb. 837 // Outside the WebCore namespace for ease of invocation from gdb.
833 void showLayerTree(const blink::PaintLayer*); 838 void showLayerTree(const blink::PaintLayer*);
834 void showLayerTree(const blink::LayoutObject*); 839 void showLayerTree(const blink::LayoutObject*);
835 #endif 840 #endif
836 841
837 #endif // Layer_h 842 #endif // Layer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698