Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 1581593003: Skip PaintPhaseFloat if no floats in a layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@OutlinePhase
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 619
620 LayoutRect previousPaintDirtyRect() const { return m_previousPaintDirtyRect; } 620 LayoutRect previousPaintDirtyRect() const { return m_previousPaintDirtyRect; }
621 void setPreviousPaintDirtyRect(const LayoutRect& rect) { m_previousPaintDirt yRect = rect; } 621 void setPreviousPaintDirtyRect(const LayoutRect& rect) { m_previousPaintDirt yRect = rect; }
622 622
623 PaintLayerPainter::PaintResult previousPaintResult() const { return static_c ast<PaintLayerPainter::PaintResult>(m_previousPaintResult); } 623 PaintLayerPainter::PaintResult previousPaintResult() const { return static_c ast<PaintLayerPainter::PaintResult>(m_previousPaintResult); }
624 void setPreviousPaintResult(PaintLayerPainter::PaintResult result) { m_previ ousPaintResult = static_cast<unsigned>(result); ASSERT(m_previousPaintResult == static_cast<unsigned>(result)); } 624 void setPreviousPaintResult(PaintLayerPainter::PaintResult result) { m_previ ousPaintResult = static_cast<unsigned>(result); ASSERT(m_previousPaintResult == static_cast<unsigned>(result)); }
625 625
626 bool needsPaintPhaseDescendantOutlines() const { return m_needsPaintPhaseDes cendantOutlines; } 626 bool needsPaintPhaseDescendantOutlines() const { return m_needsPaintPhaseDes cendantOutlines; }
627 void setNeedsPaintPhaseDescendantOutlines() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseDescendantOutlines = true; } 627 void setNeedsPaintPhaseDescendantOutlines() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseDescendantOutlines = true; }
628 628
629 bool needsPaintPhaseFloat() const { return m_needsPaintPhaseFloat; }
chrishtr 2016/01/22 00:14:44 Add a comment that once-float, always float.
Xianzhu 2016/01/22 00:50:24 Added full comments in https://codereview.chromium
630 void setNeedsPaintPhaseFloat() { ASSERT(isSelfPaintingLayer()); m_needsPaint PhaseFloat = true; }
631
629 PaintTiming* paintTiming(); 632 PaintTiming* paintTiming();
630 633
631 private: 634 private:
632 // Bounding box in the coordinates of this layer. 635 // Bounding box in the coordinates of this layer.
633 LayoutRect logicalBoundingBox() const; 636 LayoutRect logicalBoundingBox() const;
634 637
635 bool hasOverflowControls() const; 638 bool hasOverflowControls() const;
636 639
637 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus(); 640 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
638 641
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 unsigned m_shouldIsolateCompositedDescendants : 1; 755 unsigned m_shouldIsolateCompositedDescendants : 1;
753 756
754 // True if this layout layer just lost its grouped mapping due to the Compos itedLayerMapping being destroyed, 757 // True if this layout layer just lost its grouped mapping due to the Compos itedLayerMapping being destroyed,
755 // and we don't yet know to what graphics layer this Layer will be assigned. 758 // and we don't yet know to what graphics layer this Layer will be assigned.
756 unsigned m_lostGroupedMapping : 1; 759 unsigned m_lostGroupedMapping : 1;
757 760
758 unsigned m_needsRepaint : 1; 761 unsigned m_needsRepaint : 1;
759 unsigned m_previousPaintResult : 1; // PaintLayerPainter::PaintResult 762 unsigned m_previousPaintResult : 1; // PaintLayerPainter::PaintResult
760 763
761 unsigned m_needsPaintPhaseDescendantOutlines : 1; 764 unsigned m_needsPaintPhaseDescendantOutlines : 1;
765 unsigned m_needsPaintPhaseFloat : 1;
762 766
763 LayoutBoxModelObject* m_layoutObject; 767 LayoutBoxModelObject* m_layoutObject;
764 768
765 PaintLayer* m_parent; 769 PaintLayer* m_parent;
766 PaintLayer* m_previous; 770 PaintLayer* m_previous;
767 PaintLayer* m_next; 771 PaintLayer* m_next;
768 PaintLayer* m_first; 772 PaintLayer* m_first;
769 PaintLayer* m_last; 773 PaintLayer* m_last;
770 774
771 // Our current relative position offset. 775 // Our current relative position offset.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
826 830
827 } // namespace blink 831 } // namespace blink
828 832
829 #ifndef NDEBUG 833 #ifndef NDEBUG
830 // Outside the WebCore namespace for ease of invocation from gdb. 834 // Outside the WebCore namespace for ease of invocation from gdb.
831 void showLayerTree(const blink::PaintLayer*); 835 void showLayerTree(const blink::PaintLayer*);
832 void showLayerTree(const blink::LayoutObject*); 836 void showLayerTree(const blink::LayoutObject*);
833 #endif 837 #endif
834 838
835 #endif // Layer_h 839 #endif // Layer_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698