Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1581573004: Audio Player: Notify track metadata update to track-list element explicitly. (Closed)

Created:
4 years, 11 months ago by fukino
Modified:
4 years, 11 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audio Player: Notify track metadata update to track-list element explicitly. To re-render the track-list element, the metadata change needs to be notified to the track-list element explicitly. BUG=575151 TEST=manual test Committed: https://crrev.com/69b3f0b75b10ef9766e34140dc648e6aceaefd6d Cr-Commit-Position: refs/heads/master@{#369393}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a check for index range. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ui/file_manager/audio_player/elements/audio_player.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
fukino
PTAL. Thanks!
4 years, 11 months ago (2016-01-13 05:33:06 UTC) #2
fukino
Ping. > Yoshiki-san
4 years, 11 months ago (2016-01-14 06:08:43 UTC) #3
yoshiki
lgtm with nit https://codereview.chromium.org/1581573004/diff/1/ui/file_manager/audio_player/elements/audio_player.js File ui/file_manager/audio_player/elements/audio_player.js (right): https://codereview.chromium.org/1581573004/diff/1/ui/file_manager/audio_player/elements/audio_player.js#newcode356 ui/file_manager/audio_player/elements/audio_player.js:356: notifyTrackMetadataUpdated: function(index) { nit: should we ...
4 years, 11 months ago (2016-01-14 11:10:27 UTC) #4
fukino
Thank you! https://codereview.chromium.org/1581573004/diff/1/ui/file_manager/audio_player/elements/audio_player.js File ui/file_manager/audio_player/elements/audio_player.js (right): https://codereview.chromium.org/1581573004/diff/1/ui/file_manager/audio_player/elements/audio_player.js#newcode356 ui/file_manager/audio_player/elements/audio_player.js:356: notifyTrackMetadataUpdated: function(index) { On 2016/01/14 11:10:27, yoshiki ...
4 years, 11 months ago (2016-01-14 11:32:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581573004/20001
4 years, 11 months ago (2016-01-14 11:33:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 11:56:54 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 11:58:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69b3f0b75b10ef9766e34140dc648e6aceaefd6d
Cr-Commit-Position: refs/heads/master@{#369393}

Powered by Google App Engine
This is Rietveld 408576698