use default initialization for flattenables

use default initialization for flattenables

Previously initialization of effects subclasses was duplicated in two files:

SkGlobalInitialization_chromium.cpp
SkGlobalInitialization_default.cpp

With the thought that "default" would be basically everything, and "chromium" would be a filtered set eliminating insecure filters (e.g. picture-based filters).

However, the two files are the same, and control over pictures has moved to a build flag SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS, since pictures can be embedded inside other effects class, making the class-level control to coarse-grained.

This change eliminates the duplicate file, so that subsequent changes will be tested in both chrome and skia.

BUG=

Committed: https://crrev.com/b5276c605bb508d04f94b45e4f56540546f62888
Cr-Commit-Position: refs/heads/master@{#369178}

[reed1, 2016-01-13 13:55:13]

Description was changed from

==========
use default initialization for flattenables -- control for security is handled
within classes

BUG=
==========

to

==========
use default initialization for flattenables

Previously initialization of effects subclasses was duplicated in two files:

SkGlobalInitialization_chromium.cpp
SkGlobalInitialization_default.cpp

With the thought that "default" would be basically everything, and "chromium"
would be a filtered set eliminating insecure filters (e.g. picture-based
filters).

However, the two files are the same, and control over pictures has moved to a
build flag SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS, since pictures can be
embedded inside other effects class, making the class-level control to
coarse-grained.

This change eliminates the duplicate file, so that subsequent changes will be
tested in both chrome and skia.

BUG=
==========

[reed1, 2016-01-13 13:55:20]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 13:55:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581533007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581533007/1

[reed1, 2016-01-13 13:55:41]

reed@google.com changed reviewers:
+ fmalita@chromium.org, mtklein@chromium.org, robertphillips@chromium.org

[mtklein_C, 2016-01-13 14:04:22]

lgtm

This surprised me so I double-checked for myself.  The only difference between
the two files is some small disagreement about the proper alphabetical order of
   SkColorCubeFilter
   SkColorFilterShader
   SkColorMatrixFilter

[reed1, 2016-01-13 14:10:03]

The CQ bit was unchecked by reed@google.com

[f(malita), 2016-01-13 14:10:40]

lgtm

[reed1, 2016-01-13 14:11:15]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-01-13 14:11:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581533007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581533007/1

[robertphillips, 2016-01-13 15:19:37]

robertphillips@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-01-13 15:19:37]

lgtm

[commit-bot: I haz the power, 2016-01-13 15:36:13]

Description was changed from

==========
use default initialization for flattenables

Previously initialization of effects subclasses was duplicated in two files:

SkGlobalInitialization_chromium.cpp
SkGlobalInitialization_default.cpp

With the thought that "default" would be basically everything, and "chromium"
would be a filtered set eliminating insecure filters (e.g. picture-based
filters).

However, the two files are the same, and control over pictures has moved to a
build flag SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS, since pictures can be
embedded inside other effects class, making the class-level control to
coarse-grained.

This change eliminates the duplicate file, so that subsequent changes will be
tested in both chrome and skia.

BUG=
==========

to

==========
use default initialization for flattenables

Previously initialization of effects subclasses was duplicated in two files:

SkGlobalInitialization_chromium.cpp
SkGlobalInitialization_default.cpp

With the thought that "default" would be basically everything, and "chromium"
would be a filtered set eliminating insecure filters (e.g. picture-based
filters).

However, the two files are the same, and control over pictures has moved to a
build flag SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS, since pictures can be
embedded inside other effects class, making the class-level control to
coarse-grained.

This change eliminates the duplicate file, so that subsequent changes will be
tested in both chrome and skia.

BUG=
==========

[commit-bot: I haz the power, 2016-01-13 15:36:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-13 15:38:02]

Description was changed from

==========
use default initialization for flattenables

Previously initialization of effects subclasses was duplicated in two files:

SkGlobalInitialization_chromium.cpp
SkGlobalInitialization_default.cpp

With the thought that "default" would be basically everything, and "chromium"
would be a filtered set eliminating insecure filters (e.g. picture-based
filters).

However, the two files are the same, and control over pictures has moved to a
build flag SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS, since pictures can be
embedded inside other effects class, making the class-level control to
coarse-grained.

This change eliminates the duplicate file, so that subsequent changes will be
tested in both chrome and skia.

BUG=
==========

to

==========
use default initialization for flattenables

Previously initialization of effects subclasses was duplicated in two files:

SkGlobalInitialization_chromium.cpp
SkGlobalInitialization_default.cpp

With the thought that "default" would be basically everything, and "chromium"
would be a filtered set eliminating insecure filters (e.g. picture-based
filters).

However, the two files are the same, and control over pictures has moved to a
build flag SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS, since pictures can be
embedded inside other effects class, making the class-level control to
coarse-grained.

This change eliminates the duplicate file, so that subsequent changes will be
tested in both chrome and skia.

BUG=

Committed: https://crrev.com/b5276c605bb508d04f94b45e4f56540546f62888
Cr-Commit-Position: refs/heads/master@{#369178}
==========

[commit-bot: I haz the power, 2016-01-13 15:38:03]

Patchset 1 (id:??) landed as
https://crrev.com/b5276c605bb508d04f94b45e4f56540546f62888
Cr-Commit-Position: refs/heads/master@{#369178}