Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1581513002: Fix dangling-else warnings in fusl (Closed)

Created:
4 years, 11 months ago by kulakowski
Modified:
4 years, 11 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix dangling-else warnings in fusl R=viettrungluu@chromium.org Temporarily suppress spammy warnings in fusl build Committed: https://chromium.googlesource.com/external/mojo/+/e56d137b0a3d4077a4278c8165986b24f608200d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M fusl/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M fusl/src/ctype/towctrans.c View 1 chunk +4 lines, -2 lines 1 comment Download
M fusl/src/network/dn_skipname.c View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 4 (1 generated)
viettrungluu
You didn't upload the change correctly (I'm guessing you forgot to make a new branch). ...
4 years, 11 months ago (2016-01-12 16:47:50 UTC) #1
kulakowski
On 2016/01/12 16:47:50, viettrungluu wrote: > You didn't upload the change correctly (I'm guessing you ...
4 years, 11 months ago (2016-01-12 17:34:30 UTC) #2
kulakowski
4 years, 11 months ago (2016-01-12 17:36:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e56d137b0a3d4077a4278c8165986b24f608200d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698