[SystemInfo API] Add Storage Watch API Definition.

[SystemInfo API] Add Storage Watch API Definition.

BUG=177605
TEST=compiled

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204019

[Haojian Wu, 2013-05-23 05:03:10]

@hongbo, @lei please review the api definition. Thanks.

[Lei Zhang, 2013-05-23 16:04:58]

You probably have a typo in your TEST= line.

https://codereview.chromium.org/15815002/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/system_info_storage/system_info_storage_api.h
(right):

https://codereview.chromium.org/15815002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/system_info_storage/system_info_storage_api.h:27:
class SystemInfoStorageAddWatchFunction : public SyncExtensionFunction {
If you are going to copy the mediaGalleriesPrivate.addGalleryWatch functionality
over later, then you probably want to keep this async.

https://codereview.chromium.org/15815002/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_function_histogram_value.h (right):

https://codereview.chromium.org/15815002/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_function_histogram_value.h:452:
EXPERIMENTAL_SYSTEMINFO_STORAGE_ADDWATCH,
Please read the comments at the top of the file.

[Haojian Wu, 2013-05-23 16:42:46]

Done.

https://codereview.chromium.org/15815002/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/system_info_storage/system_info_storage_api.h
(right):

https://codereview.chromium.org/15815002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/system_info_storage/system_info_storage_api.h:27:
class SystemInfoStorageAddWatchFunction : public SyncExtensionFunction {
On 2013/05/23 16:04:58, Lei Zhang wrote:
> If you are going to copy the mediaGalleriesPrivate.addGalleryWatch
functionality
> over later, then you probably want to keep this async.

Done.

https://codereview.chromium.org/15815002/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_function_histogram_value.h (right):

https://codereview.chromium.org/15815002/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_function_histogram_value.h:452:
EXPERIMENTAL_SYSTEMINFO_STORAGE_ADDWATCH,
On 2013/05/23 16:04:58, Lei Zhang wrote:
> Please read the comments at the top of the file.

Done.

[Lei Zhang, 2013-05-23 17:10:53]

lgtm

Rather than putting the functions in alphabetical order, can you put keep it as
(add, remove), getAll, removeAll?

[Hongbo Min, 2013-05-24 01:01:46]

lgtm. thanks.

[Haojian Wu, 2013-05-24 03:00:20]

On 2013/05/23 17:10:53, Lei Zhang wrote:
> lgtm
> 
> Rather than putting the functions in alphabetical order, can you put keep it
as
> (add, remove), getAll, removeAll?

Done. 

Right now, should I need to find another reviewer or just hit the commit button?

[Hongbo Min, 2013-05-24 03:02:19]

Just have a try.

[commit-bot: I haz the power, 2013-05-24 03:08:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/15815002/15001

[commit-bot: I haz the power, 2013-05-24 03:08:43]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 526.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
61eb3ad7e320c161272758a9588d990c5ff8f44f..c6fae8411c20e10bc85c21b8831ea377c11e0462
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -526,6 +526,10 @@ enum HistogramValue {
   SOCKET_MULTICAST_SET_LOOPBACK_MODE,
   SOCKET_MULTICAST_GET_JOINED_GROUPS,
   EXPERIMENTAL_ACCESSIBILITY_SETNATIVEACCESSIBILITYENABLED,
+  EXPERIMENTAL_SYSTEMINFO_STORAGE_ADDWATCH,
+  EXPERIMENTAL_SYSTEMINFO_STORAGE_REMOVEWATCH,
+  EXPERIMENTAL_SYSTEMINFO_STORAGE_GETALLWATCH,
+  EXPERIMENTAL_SYSTEMINFO_STORAGE_REMOVEALLWATCH,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-05-24 08:41:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/15815002/20001

[commit-bot: I haz the power, 2013-05-24 08:41:40]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 531.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
b1c7f055e1962623ae1af6baffee84d14e2db344..479085706ba444c2bdb7388f021da4c18a21c1d7
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -531,6 +531,10 @@ enum HistogramValue {
   METRICSPRIVATE_GETISCRASHRECORDINGENABLED,
   IDENTITYPRIVATE_GETRESOURCES,
   NOTIFICATIONS_GET_ALL,
+  EXPERIMENTAL_SYSTEMINFO_STORAGE_ADDWATCH,
+  EXPERIMENTAL_SYSTEMINFO_STORAGE_REMOVEWATCH,
+  EXPERIMENTAL_SYSTEMINFO_STORAGE_GETALLWATCH,
+  EXPERIMENTAL_SYSTEMINFO_STORAGE_REMOVEALLWATCH,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-05-24 09:03:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/15815002/24001

[commit-bot: I haz the power, 2013-05-30 05:19:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/15815002/38001

[commit-bot: I haz the power, 2013-06-04 12:29:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/15815002/43001

[commit-bot: I haz the power, 2013-06-04 13:31:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/15815002/43001

[commit-bot: I haz the power, 2013-06-04 19:54:15]

Change committed as 204019