Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: components/metrics/metrics_log.cc

Issue 1581473002: Remove base/win/metro.{cc|h} and some associated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_log.cc
diff --git a/components/metrics/metrics_log.cc b/components/metrics/metrics_log.cc
index 3f2d0081f0dc79d9b7bca7aac18228f0a6709dd5..728068f7b4e81a40dfea20eac8034f04e43662bf 100644
--- a/components/metrics/metrics_log.cc
+++ b/components/metrics/metrics_log.cc
@@ -40,8 +40,6 @@
#endif
#if defined(OS_WIN)
-#include "base/win/metro.h"
-
// http://blogs.msdn.com/oldnewthing/archive/2004/10/25/247180.aspx
extern "C" IMAGE_DOS_HEADER __ImageBase;
#endif
@@ -329,15 +327,6 @@ void MetricsLog::RecordEnvironment(
SystemProfileProto::OS* os = system_profile->mutable_os();
std::string os_name = base::SysInfo::OperatingSystemName();
-#if defined(OS_WIN)
- // TODO(mad): This only checks whether the main process is a Metro process at
- // upload time; not whether the collected metrics were all gathered from
- // Metro. This is ok as an approximation for now, since users will rarely be
- // switching from Metro to Desktop mode; but we should re-evaluate whether we
- // can distinguish metrics more cleanly in the future: http://crbug.com/140568
- if (base::win::IsMetroProcess())
- os_name += " (Metro)";
-#endif
os->set_name(os_name);
os->set_version(base::SysInfo::OperatingSystemVersion());
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698