chrome/browser/extensions/chrome_requirements_checker.cc - Issue 1581473002: Remove base/win/metro.{cc|h} and some associated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_requirements_checker.cc

Issue 1581473002: Remove base/win/metro.{cc|h} and some associated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_select_file_dialog_factory_win.cc ('k') | chrome/browser/first_run/first_run_internal_win.cc » ('j') | chrome/installer/setup/install.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_requirements_checker.cc

diff --git a/chrome/browser/extensions/chrome_requirements_checker.cc b/chrome/browser/extensions/chrome_requirements_checker.cc

index 5fcb2d087a16d4252360a85ef769cd027ee78924..64fbc3e3ab4b6bc3dda59918d563b6a9b849ccb8 100644

--- a/chrome/browser/extensions/chrome_requirements_checker.cc

+++ b/chrome/browser/extensions/chrome_requirements_checker.cc

@@ -15,10 +15,6 @@

#include "gpu/config/gpu_feature_type.h"

#include "ui/base/l10n/l10n_util.h"

-#if defined(OS_WIN)

-#include "base/win/metro.h"

-#endif

namespace extensions {

ChromeRequirementsChecker::ChromeRequirementsChecker()

@@ -42,12 +38,6 @@ void ChromeRequirementsChecker::Check(

errors_.push_back(

l10n_util::GetStringUTF8(IDS_EXTENSION_NPAPI_NOT_SUPPORTED));

#endif

-#if defined(OS_WIN)

- if (base::win::IsMetroProcess()) {

- errors_.push_back(

- l10n_util::GetStringUTF8(IDS_EXTENSION_NPAPI_NOT_SUPPORTED));

- }

-#endif

}

if (requirements.window_shape) {