Remove base/win/metro.{cc|h} and some associated code

win8/delegate_execute/command_execute_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 // Implementation of the CommandExecuteImpl class which implements the
 // IExecuteCommand and related interfaces for handling ShellExecute based
 // launches of the Chrome browser.
 
 #include "win8/delegate_execute/command_execute_impl.h"
 
 #include <shlguid.h>
 
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
 #include "base/strings/utf_string_conversions.h"
-#include "base/win/metro.h"
 #include "base/win/registry.h"
 #include "base/win/scoped_co_mem.h"
 #include "base/win/scoped_handle.h"
 #include "base/win/scoped_process_information.h"
 #include "base/win/win_util.h"
 #include "base/win/windows_version.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/installer/util/browser_distribution.h"
@@ skipping 419 matching lines @@
   if (GetAsyncKeyState(VK_SHIFT) && GetAsyncKeyState(VK_F11)) {
     AtlTrace("Hotkey: launching in immersive mode\n");
     launch_mode = ECHUIM_IMMERSIVE;
     launch_mode_determined = true;
     return launch_mode;
   }
 
   // From here on, if we can, we will write the outcome
   // of this function to the registry.
   if (parameters_.HasSwitch(switches::kForceImmersive)) {
     launch_mode = ECHUIM_IMMERSIVE;

[gab, 2016/01/14 03:30:37]

We should probably get rid of all ECHUIM_IMMERSIVE and AHE_IMMERSIVE options in
delegate_execute, just having them still there while the support backing it is
gone in M49 scares me (since branch cut is imminent and the rest of the removal
won't make it..).

I guess it's all behind switches and keyboard tricks but still...

     launch_mode_determined = true;
     parameters_ = base::CommandLine(base::CommandLine::NO_PROGRAM);
   } else if (parameters_.HasSwitch(switches::kForceDesktop)) {
     launch_mode = ECHUIM_DESKTOP;
     launch_mode_determined = true;
     parameters_ = base::CommandLine(base::CommandLine::NO_PROGRAM);
   }
 
   base::win::RegKey reg_key;
   LONG key_result = reg_key.Create(HKEY_CURRENT_USER,
@@ skipping 12 matching lines @@
     return launch_mode;
   }
 
   if (launch_mode_determined) {
     AtlTrace("Launch mode forced by cmdline to %s\n", modes[launch_mode]);
     reg_key.WriteValue(chrome::kLaunchModeValue,
                        static_cast<DWORD>(launch_mode));
     return launch_mode;
   }
 
-  if (!base::win::IsChromeMetroSupported()) {
-    launch_mode = ECHUIM_DESKTOP;
-    launch_mode_determined = true;
-    return launch_mode;
-  }
-
-  // Use the previous mode if available. Else launch in desktop mode.
-  DWORD reg_value;
-  if (reg_key.ReadValueDW(chrome::kLaunchModeValue,

[gab, 2016/01/12 21:11:04]

Please add cleanup code to delete this value instead of leaving it rotting
behind.

[scottmg, 2016/01/13 20:48:16]

Do we normally do this? How long should we keep the code around for in that
case?

[gab, 2016/01/14 03:10:27]

Yes. We do this all over the installer and in chrome prefs. We try not to leave
deprecated state behind. I typically put a TODO to remove the cleanup code in 3
milestones from now (and it typically stays there for a while longer until
somebody notices so >= 6 months on Stable which is plenty for a value that isn't
harmful per se otherwise... we leave cleanup code for > 1 year sometimes for
things that are visible, e.g. deprecated shortcuts)

[gab, 2016/01/14 03:12:24]

Err... >= 4.5 months (18 weeks) on Stable 

-                          &reg_value) != ERROR_SUCCESS) {
-    launch_mode = ECHUIM_DESKTOP;
-    AtlTrace("Can't read registry, defaulting to %s\n", modes[launch_mode]);
-  } else if (reg_value >= ECHUIM_SYSTEM_LAUNCHER) {
-    AtlTrace("Invalid registry launch mode value %u\n", reg_value);
-    launch_mode = ECHUIM_DESKTOP;
-  } else {
-    launch_mode = static_cast<EC_HOST_UI_MODE>(reg_value);
-    AtlTrace("Launch mode forced by registry to %s\n", modes[launch_mode]);
-  }
-
+  launch_mode = ECHUIM_DESKTOP;
   launch_mode_determined = true;
   return launch_mode;
 }