Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1581443002: Restore IsolateData destructor (Closed)

Created:
4 years, 11 months ago by zra
Modified:
4 years, 11 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restore IsolateData destructor Shutdown is turned on, and the race on IsolatData deletion has been fixed, so this should be safe to re-enable. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/6c8a3e0053490e7d36de90b1954926c66cfbe72f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M runtime/bin/isolate_data.h View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zra
4 years, 11 months ago (2016-01-11 21:52:28 UTC) #3
zra
4 years, 11 months ago (2016-01-13 17:13:00 UTC) #5
Ivan Posva
LGTM -ip
4 years, 11 months ago (2016-01-13 17:18:38 UTC) #6
zra
4 years, 11 months ago (2016-01-13 18:12:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c8a3e0053490e7d36de90b1954926c66cfbe72f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698