Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1581423003: Forgot adding new file to build files (Closed)

Created:
4 years, 11 months ago by rossberg
Modified:
4 years, 11 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Forgot adding new file to build files R=hablich@chromium.org BUG=v8:4664 LOG=N Committed: https://crrev.com/2d36bdffa26bf1dc7c654c490e5b6303d2c73872 Cr-Commit-Position: refs/heads/master@{#33290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rossberg
4 years, 11 months ago (2016-01-14 10:55:23 UTC) #1
Michael Hablich
On 2016/01/14 10:55:23, rossberg wrote: lgtm
4 years, 11 months ago (2016-01-14 11:17:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581423003/1
4 years, 11 months ago (2016-01-14 11:17:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 11:36:18 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 11:37:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2d36bdffa26bf1dc7c654c490e5b6303d2c73872
Cr-Commit-Position: refs/heads/master@{#33290}

Powered by Google App Engine
This is Rietveld 408576698