src/ast/ast-literal-reindexer.cc - Issue 1581403007: Fix re-indexing for literals in do-expressions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast-literal-reindexer.cc

Issue 1581403007: Fix re-indexing for literals in do-expressions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix the regression test, focus on spreads Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/ast-literal-reindexer.cc

diff --git a/src/ast/ast-literal-reindexer.cc b/src/ast/ast-literal-reindexer.cc

index fce33e70b8f7caf9aec7a25aaf3fe1ebfa00344e..6db9a61b9b48e235b3d06020b39aae448b93dde9 100644

--- a/src/ast/ast-literal-reindexer.cc

+++ b/src/ast/ast-literal-reindexer.cc

@@ -44,7 +44,8 @@ void AstLiteralReindexer::VisitNativeFunctionLiteral(

void AstLiteralReindexer::VisitDoExpression(DoExpression* node) {

- // TODO(caitp): literals in do expressions need re-indexing too.

+ Visit(node->block());

+ Visit(node->result());

}