Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: src/ast/ast-literal-reindexer.cc

Issue 1581403007: Fix re-indexing for literals in do-expressions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast-expression-visitor.cc ('k') | test/mjsunit/harmony/regress/regress-crbug-578038.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast-literal-reindexer.cc
diff --git a/src/ast/ast-literal-reindexer.cc b/src/ast/ast-literal-reindexer.cc
index fce33e70b8f7caf9aec7a25aaf3fe1ebfa00344e..6db9a61b9b48e235b3d06020b39aae448b93dde9 100644
--- a/src/ast/ast-literal-reindexer.cc
+++ b/src/ast/ast-literal-reindexer.cc
@@ -44,7 +44,8 @@ void AstLiteralReindexer::VisitNativeFunctionLiteral(
void AstLiteralReindexer::VisitDoExpression(DoExpression* node) {
- // TODO(caitp): literals in do expressions need re-indexing too.
+ Visit(node->block());
caitp (gmail) 2016/01/15 17:48:00 The thing that worries me is, which function the r
nickie 2016/01/15 20:18:29 Initializers in arrow function parameters is exact
caitp (gmail) 2016/01/15 20:25:30 In a RewritableExpression, any ObjectLiteral or Ar
+ Visit(node->result());
caitp (gmail) 2016/01/15 17:48:00 `result` is always a VariableProxy, so it probably
nickie 2016/01/15 20:18:29 I was of the impression that the result can be a t
}
« no previous file with comments | « src/ast/ast-expression-visitor.cc ('k') | test/mjsunit/harmony/regress/regress-crbug-578038.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698