Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: src/ast/ast-expression-visitor.cc

Issue 1581403007: Fix re-indexing for literals in do-expressions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix the regression test, focus on spreads Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ast/ast-literal-reindexer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ast/ast-expression-visitor.h" 7 #include "src/ast/ast-expression-visitor.h"
8 8
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/ast/scopes.h" 10 #include "src/ast/scopes.h"
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 RECURSE_EXPRESSION(VisitDeclarations(scope->declarations())); 201 RECURSE_EXPRESSION(VisitDeclarations(scope->declarations()));
202 RECURSE_EXPRESSION(VisitStatements(expr->body())); 202 RECURSE_EXPRESSION(VisitStatements(expr->body()));
203 } 203 }
204 204
205 205
206 void AstExpressionVisitor::VisitNativeFunctionLiteral( 206 void AstExpressionVisitor::VisitNativeFunctionLiteral(
207 NativeFunctionLiteral* expr) {} 207 NativeFunctionLiteral* expr) {}
208 208
209 209
210 void AstExpressionVisitor::VisitDoExpression(DoExpression* expr) { 210 void AstExpressionVisitor::VisitDoExpression(DoExpression* expr) {
211 VisitExpression(expr);
211 RECURSE(VisitBlock(expr->block())); 212 RECURSE(VisitBlock(expr->block()));
212 RECURSE(VisitVariableProxy(expr->result())); 213 RECURSE(VisitVariableProxy(expr->result()));
213 } 214 }
214 215
215 216
216 void AstExpressionVisitor::VisitConditional(Conditional* expr) { 217 void AstExpressionVisitor::VisitConditional(Conditional* expr) {
217 VisitExpression(expr); 218 VisitExpression(expr);
218 RECURSE_EXPRESSION(Visit(expr->condition())); 219 RECURSE_EXPRESSION(Visit(expr->condition()));
219 RECURSE_EXPRESSION(Visit(expr->then_expression())); 220 RECURSE_EXPRESSION(Visit(expr->then_expression()));
220 RECURSE_EXPRESSION(Visit(expr->else_expression())); 221 RECURSE_EXPRESSION(Visit(expr->else_expression()));
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 402
402 void AstExpressionVisitor::VisitRewritableAssignmentExpression( 403 void AstExpressionVisitor::VisitRewritableAssignmentExpression(
403 RewritableAssignmentExpression* expr) { 404 RewritableAssignmentExpression* expr) {
404 VisitExpression(expr); 405 VisitExpression(expr);
405 RECURSE(Visit(expr->expression())); 406 RECURSE(Visit(expr->expression()));
406 } 407 }
407 408
408 409
409 } // namespace internal 410 } // namespace internal
410 } // namespace v8 411 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/ast/ast-literal-reindexer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698