Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1581403004: Fix crash in Canvas2DLayerBridge flushing + reliability metrics (Closed)

Created:
4 years, 11 months ago by Justin Novosad
Modified:
4 years, 11 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), asvitkine+watch_chromium.org, blink-reviews, vmpstr+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in Canvas2DLayerBridge flushing + reliability metrics This change fixes a crash that occured when an SkSurface allocation failure happened while switching a canvas to non-deferred rendering mode. This failure induced an inconsistent state that was causing a crash the next time the canvas was flushed. The allocation failure that was causing the crash will now fail silently. New histogram metrics will track the prevalence of these allocation failures. BUG=576496 Committed: https://crrev.com/826ccd3c4bd0a6639fb70899cc94c33bc2dc9385 Cr-Commit-Position: refs/heads/master@{#369565}

Patch Set 1 #

Patch Set 2 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -15 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 6 chunks +50 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CanvasMetrics.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Justin Novosad
PTAL
4 years, 11 months ago (2016-01-14 19:09:47 UTC) #2
Alexei Svitkine (slow)
histograms lgtm
4 years, 11 months ago (2016-01-14 19:11:00 UTC) #3
Stephen White
LGTM
4 years, 11 months ago (2016-01-14 19:15:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581403004/1
4 years, 11 months ago (2016-01-14 19:15:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581403004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581403004/20001
4 years, 11 months ago (2016-01-14 20:44:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 22:10:33 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 22:12:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/826ccd3c4bd0a6639fb70899cc94c33bc2dc9385
Cr-Commit-Position: refs/heads/master@{#369565}

Powered by Google App Engine
This is Rietveld 408576698