Issue 15814005: callback handler map not correctly populated by direct use of SetCallHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15814005: callback handler map not correctly populated by direct use of SetCallHandler (Closed)

Created:
7 years, 7 months ago by dcarney

Modified:
7 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

callback handler map not correctly populated by direct use of SetCallHandler R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14789

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	src/api.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Sven Panne

LGTM (but I think I need an offline in-depth explanation of the CallbackTable :-)

7 years, 7 months ago (2013-05-24 07:37:15 UTC) #1

dcarney

7 years, 7 months ago (2013-05-24 08:04:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r14789 (presubmit successful).